Refactor codebase to use unnamed variables where possible

Author: mikosik

src/common/src/main/java/org/smoothbuild/common/filesystem/mem/MemoryFileSystem.java

@@ -138,7 +138,7 @@ private <T> T createObject(
         case MemoryDir dir -> {
           return creator.apply(dir);
         }
-        case MemoryFile f -> throw new IOException(error.get() + "Parent dir does not exist.");
+        case MemoryFile _ -> throw new IOException(error.get() + "Parent dir does not exist.");
       }
     }
   }

src/compiler-backend/src/main/java/org/smoothbuild/compilerbackend/TypeSbTranslator.java

@@ -36,12 +36,12 @@ public Map<STypeVar, BType> typeVarMap() {
   public BType translate(SType type) throws SbTranslatorException {
     return switch (type) {
       case SArrayType sArrayType -> translate(sArrayType);
-      case SBlobType sBlobType -> bytecodeF.blobType();
-      case SBoolType sBoolType -> bytecodeF.boolType();
+      case SBlobType _ -> bytecodeF.blobType();
+      case SBoolType _ -> bytecodeF.boolType();
       case SFuncType sFuncType -> translate(sFuncType);
-      case SIntType sIntType -> bytecodeF.intType();
+      case SIntType _ -> bytecodeF.intType();
       case STypeVar sTypeVar -> translate(sTypeVar);
-      case SStringType sStringType -> bytecodeF.stringType();
+      case SStringType _ -> bytecodeF.stringType();
       case SStructType sStructType -> translate(sStructType);
       case STupleType sTupleType -> translate(sTupleType);
       case SInterfaceType sInterfaceType -> throw unexpectedCaseException(sInterfaceType);

src/compiler-frontend/src/main/java/org/smoothbuild/compilerfrontend/compile/ast/PModuleVisitor.java

@@ -57,7 +57,7 @@ public void visitPolyEvaluable(PPolyEvaluable pPolyEvaluable) throws T {
   public void visitTypeParams(PTypeParams pExplicitTypeParams) {
     switch (pExplicitTypeParams) {
       case PExplicitTypeParams explicit -> explicit.typeParams().foreach(this::visitTypeParam);
-      case PImplicitTypeParams implicit -> {}
+      case PImplicitTypeParams _ -> {}
     }
   }
 

src/compiler-frontend/src/main/java/org/smoothbuild/compilerfrontend/compile/task/GenerateFqns.java

@@ -57,8 +57,7 @@ public void visit(PContainer pContainer) {
       var name =
           switch (pContainer) {
             case PLambda pLambda -> nameOf(pLambda);
-            case PModule pModule -> Result.<Name>err("");
-            case PPolyEvaluable pPolyEvaluable -> Result.<Name>err("");
+            case PModule _, PPolyEvaluable _ -> Result.<Name>err("");
             case PNamedEvaluable pNamedEvaluable -> nameOf(pNamedEvaluable);
             case PStruct pStruct -> nameOf(pStruct);
           };
@@ -85,7 +84,7 @@ public void visitType(PType pType) throws RuntimeException {
           parseReference(pTypeReference.nameText())
               .ifErr(e -> logIllegalTypeReference(pTypeReference, e))
               .ifOk(pTypeReference::setFqn);
-        case PImplicitType pImplicitType -> {}
+        case PImplicitType _ -> {}
       }
     }
 

src/compiler-frontend/src/main/java/org/smoothbuild/compilerfrontend/compile/task/GenerateScopes.java

@@ -85,7 +85,7 @@ private PScope createScopeFor(PContainer pContainer) {
         case PModule pModule -> initializeScopeFor(pModule);
         case PStruct pStruct -> initializeScopeFor(pStruct);
         case PPolyEvaluable pPolyEvaluable -> initializeScopeFor(pPolyEvaluable);
-        case PNamedValue pNamedValue -> {}
+        case PNamedValue _ -> {}
         case PConstructor pConstructor -> initializeScopeFor(pConstructor);
         case PFunc pFunc -> initializeScopeFor(pFunc);
       }
@@ -121,7 +121,7 @@ private void initializeScopeFor(PPolyEvaluable pPolyEvaluable) {
         // gluing function name and parameter name using '~' into a name.
         case PExplicitTypeParams explicit ->
           explicit.typeParams().foreach(type -> addType(type, type.name()));
-        case PImplicitTypeParams implicit -> {}
+        case PImplicitTypeParams _ -> {}
       }
     }
 

src/compiler-frontend/src/main/java/org/smoothbuild/compilerfrontend/compile/task/ResolveReferences.java

@@ -73,7 +73,7 @@ public void visitType(PType pType) {
         case PFuncType func -> visitFuncType(func);
         case PTupleType tuple -> visitTupleType(tuple);
         case PTypeReference pTypeReference -> visitExplicitType(pTypeReference);
-        case PImplicitType pImplicitType -> {}
+        case PImplicitType _ -> {}
       }
     }
 

src/virtual-machine/src/main/java/org/smoothbuild/virtualmachine/evaluate/execute/BEvaluate.java

@@ -115,7 +115,7 @@ Promise<Maybe<BValue>> doScheduleJob(Job job) throws BytecodeException {
         case BFold fold -> scheduleFold(job, fold);
         case BIf if_ -> scheduleIf(job, if_);
         case BInvoke invoke -> scheduleOperation(job, invoke, InvokeStep::new);
-        case BLambda lambda -> scheduleInlineTask(job);
+        case BLambda _ -> scheduleInlineTask(job);
         case BMap map -> scheduleMap(job, map);
         case BOrder order -> scheduleOperation(job, order, OrderStep::new);
         case BPick pick -> scheduleOperation(job, pick, PickStep::new);

src/virtual-machine/src/main/java/org/smoothbuild/virtualmachine/evaluate/step/StepHashes.java

@@ -8,12 +8,12 @@
 public class StepHashes {
   public static Hash stepHash(Step step) {
     return switch (step) {
-      case CombineStep combineStep -> combineHash();
-      case ChooseStep chooseStep -> chooseHash();
-      case InvokeStep invokeStep -> invokeHash();
+      case CombineStep _ -> combineHash();
+      case ChooseStep _ -> chooseHash();
+      case InvokeStep _ -> invokeHash();
       case OrderStep orderStep -> orderHash(orderStep.evaluationType());
-      case PickStep pickStep -> pickHash();
-      case SelectStep selectStep -> selectHash();
+      case PickStep _ -> pickHash();
+      case SelectStep _ -> selectHash();
     };
   }