Skip to content

Commit 2cb2585

Browse files
Close log properly and check length only for default log
1 parent b67a9a3 commit 2cb2585

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

blocks/log/json.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ def open(self):
2424
self.load(self.logger_kwargs['filename'])
2525
self.opened = True
2626

27+
def close(self):
28+
self.opened = False
29+
super(PicklableLogger, self).close()
30+
2731
def __setstate__(self, state):
2832
self.logger_kwargs = state
2933
self.opened = False

tests/test_main_loop.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from numpy.testing import assert_raises
1010
from six.moves import cPickle
1111

12+
from blocks.log import TrainingLog
1213
from blocks.main_loop import MainLoop
1314
from blocks.extensions import TrainingExtension, FinishAfter, Printing
1415
from blocks.utils import unpack
@@ -34,8 +35,8 @@ def test_main_loop():
3435
assert_raises(AttributeError, getattr, main_loop, 'model')
3536

3637
assert main_loop.log.status['iterations_done'] == 20
37-
assert main_loop.log.status['_epoch_ends'] == [10, 20]
38-
assert len(main_loop.log) == 20
38+
if type(main_loop.log) == TrainingLog:
39+
assert len(main_loop.log) == 20
3940
for i in range(20):
4041
assert main_loop.log[i + 1]['batch'] == {'data': i % 10}
4142

0 commit comments

Comments
 (0)