clean up tests

Author: miladrahimi

tests/GroupedMappingTest.php renamed to tests/GroupingTest.php

@@ -14,14 +14,14 @@
 use MiladRahimi\PhpRouter\Tests\Classes\SampleMiddleware;
 use Throwable;
 
-class GroupedMappingTest extends TestCase
+class GroupingTest extends TestCase
 {
     /**
      * @throws Throwable
      */
-    public function test_simple_group_routing()
+    public function test_simple_group()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group([], function (Router $router) {
             $router->map('GET', '/', $this->simpleController());
@@ -35,15 +35,15 @@ public function test_simple_group_routing()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_middleware()
+    public function test_middleware_object()
     {
         $groupMiddleware = new SampleMiddleware(777);
 
         $groupAttributes = [
             RouteAttributes::MIDDLEWARE => $groupMiddleware,
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) {
             $router->map('GET', '/', $this->simpleController());
@@ -58,13 +58,13 @@ public function test_group_routing_with_middleware()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_string_middleware()
+    public function test_string_middleware()
     {
         $groupAttributes = [
             RouteAttributes::MIDDLEWARE => SampleMiddleware::class,
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) {
             $router->map('GET', '/', $this->simpleController());
@@ -78,7 +78,7 @@ public function test_group_routing_with_string_middleware()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_a_group_and_a_route_middleware()
+    public function test_middleware_it_should_ignore_group_middleware_where_route_middleware_is_present()
     {
         $groupMiddleware = new SampleMiddleware(1001);
         $routeMiddleware = new SampleMiddleware(1002);
@@ -87,7 +87,7 @@ public function test_group_routing_with_a_group_and_a_route_middleware()
             RouteAttributes::MIDDLEWARE => $groupMiddleware,
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) use ($routeMiddleware) {
             $router->map('GET', '/', $this->simpleController(), $routeMiddleware);
@@ -103,15 +103,15 @@ public function test_group_routing_with_a_group_and_a_route_middleware()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_prefix()
+    public function test_prefix()
     {
         $this->mockRequest(HttpMethods::GET, 'http://example.com/group/page');
 
         $groupAttributes = [
             RouteAttributes::PREFIX => '/group',
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) {
             $router->map('GET', '/page', $this->simpleController());
@@ -125,15 +125,15 @@ public function test_group_routing_with_prefix()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_domain()
+    public function test_domain()
     {
         $this->mockRequest(HttpMethods::GET, 'http://sub.domain.tld/');
 
         $groupAttributes = [
             RouteAttributes::DOMAIN => 'sub.domain.tld',
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) {
             $router->map('GET', '/', $this->simpleController());
@@ -147,15 +147,15 @@ public function test_group_routing_with_domain()
     /**
      * @throws Throwable
      */
-    public function test_group_routing_with_domains_it_should_ignore_group_domain_when_the_route_has_one()
+    public function test_domain_it_should_ignore_group_domain_where_route_domain_is_present()
     {
         $this->mockRequest(HttpMethods::GET, 'http://sub2.domain.tld/');
 
         $groupAttributes = [
             RouteAttributes::DOMAIN => 'sub1.domain.tld',
         ];
 
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->group($groupAttributes, function (Router $router) {
             $router->map('GET', '/', $this->simpleController(), [], 'sub2.domain.tld');
@@ -169,9 +169,9 @@ public function test_group_routing_with_domains_it_should_ignore_group_domain_wh
     /**
      * @throws Throwable
      */
-    public function test_simple_group_routing_it_should_remove_existing_name_before_the_group()
+    public function test_naming_it_should_remove_existing_name_before_the_group()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
         $router->useName('NameForNothing');
 

tests/ResponseTest.php

@@ -22,9 +22,9 @@ class ResponseTest extends TestCase
      */
     public function test_empty_response_with_code_204()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
-        $router->map('GET', '/', function() {
+        $router->map('GET', '/', function () {
             return new EmptyResponse(204);
         });
 
@@ -38,9 +38,9 @@ public function test_empty_response_with_code_204()
      */
     public function test_html_response_with_code_200()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
-        $router->map('GET', '/', function() {
+        $router->map('GET', '/', function () {
             return new HtmlResponse('<html></html>', 200);
         });
 
@@ -55,9 +55,9 @@ public function test_html_response_with_code_200()
      */
     public function test_json_response_with_code_201()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
-        $router->map('GET', '/', function() {
+        $router->map('GET', '/', function () {
             return new JsonResponse(['a' => 'x', 'b' => 'y'], 201);
         });
 
@@ -72,9 +72,9 @@ public function test_json_response_with_code_201()
      */
     public function test_text_response_with_code_203()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
-        $router->map('GET', '/', function() {
+        $router->map('GET', '/', function () {
             return new TextResponse('Content', 203);
         });
 
@@ -89,9 +89,9 @@ public function test_text_response_with_code_203()
      */
     public function test_redirect_response_with_code_203()
     {
-        $router = $this->createRouterWithMockedProperties();
+        $router = $this->createRouter();
 
-        $router->map('GET', '/', function() {
+        $router->map('GET', '/', function () {
             return new RedirectResponse('https://miladrahimi.com');
         });
 
@@ -101,4 +101,4 @@ public function test_redirect_response_with_code_203()
         $this->assertEquals('', $this->getPublisher($router)->output);
         $this->assertContains('location: https://miladrahimi.com', $this->getPublisher($router)->headerLines);
     }
-}
+}