add tests

Author: miladrahimi

src/Dispatching/Caller.php

@@ -67,16 +67,16 @@ public function call($callable)
                 throw new InvalidCallableException('Invalid callable: ' . implode(',', $callable));
             }
 
-            list($class, $method) = $callable;
+            [$class, $method] = $callable;
 
             if (class_exists($class) == false) {
-                throw new InvalidCallableException("Class `$callable` not found.");
+                throw new InvalidCallableException("Class `$class` not found.");
             }
 
             $object = $this->container->instantiate($class);
 
             if (method_exists($object, $method) == false) {
-                throw new InvalidCallableException("Method `$class::$method` not found.");
+                throw new InvalidCallableException("Method `$class::$method` is not declared.");
             }
 
             $callable = [$object, $method];
@@ -89,11 +89,11 @@ public function call($callable)
                 }
             }
 
-            if (is_object($callable) && !($callable instanceof Closure)) {
+            if (is_object($callable) && !$callable instanceof Closure) {
                 if (method_exists($callable, 'handle')) {
                     $callable = [$callable, 'handle'];
                 } else {
-                    throw new InvalidCallableException("Method `$callable::handle` not found.");
+                    throw new InvalidCallableException("Method `handle` is not declared.");
                 }
             }
         }

tests/ControllerTest.php

@@ -43,6 +43,46 @@ public function test_with_an_invalid_array_as_controller_it_should_fail()
         $router->get('/', ['invalid', 'array', 'controller']);
 
         $this->expectException(InvalidCallableException::class);
+        $this->expectExceptionMessage('Invalid callable: invalid,array,controller');
+        $router->dispatch();
+    }
+
+    /**
+     * @throws Throwable
+     */
+    public function test_with_an_invalid_class_as_controller_it_should_fail()
+    {
+        $router = $this->router();
+        $router->get('/', ['InvalidController', 'show']);
+
+        $this->expectException(InvalidCallableException::class);
+        $this->expectExceptionMessage('Class `InvalidController` not found.');
+        $router->dispatch();
+    }
+
+    /**
+     * @throws Throwable
+     */
+    public function test_with_an_int_as_controller_it_should_fail()
+    {
+        $router = $this->router();
+        $router->get('/', 666);
+
+        $this->expectException(InvalidCallableException::class);
+        $this->expectExceptionMessage('Invalid callable.');
+        $router->dispatch();
+    }
+
+    /**
+     * @throws Throwable
+     */
+    public function test_with_an_handle_less_class_as_controller_it_should_fail()
+    {
+        $router = $this->router();
+        $router->get('/', SampleController::class);
+
+        $this->expectException(InvalidCallableException::class);
+        $this->expectExceptionMessage('Method `handle` is not declared.');
         $router->dispatch();
     }
 
@@ -55,6 +95,7 @@ public function test_with_an_invalid_method_as_controller_it_should_fail()
         $router->get('/', [SampleController::class, 'invalid']);
 
         $this->expectException(InvalidCallableException::class);
+        $this->expectExceptionMessage('Method `' . SampleController::class . '::invalid` is not declared.');
         $router->dispatch();
     }