Skip to content

Commit 8e18ef0

Browse files
committed
fixing GA on sandbox + benchmark
1 parent b794571 commit 8e18ef0

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

benchmark/browser/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ <h3>⏱️ Mean Execution Time</h3>
5959
</div>
6060

6161
<footer>
62-
<p>Powered by <a href="https://github.com/tinylibs/tinybench" target="_blank" onclick="gtag('event', 'click', {event_category: 'Navigation', event_label: 'Tinybench GitHub'});">Tinybench</a></p>
62+
<p>Powered by <a href="https://github.com/tinylibs/tinybench" target="_blank" onclick="if(typeof gtag==='function'){gtag('event','link_click',{'link_category':'Navigation','link_name':'tinybench_github'});}">Tinybench</a></p>
6363
</footer>
6464
</div>
6565

benchmark/browser/runner.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ class BrowserBenchmarkRunner {
3333
document.getElementById('clearBtn').addEventListener('click', () => {
3434
// Track clear action in Google Analytics
3535
if (typeof gtag === 'function') {
36-
gtag('event', 'click', {
37-
event_category: 'Benchmark',
38-
event_label: 'Clear Results'
36+
gtag('event', 'clear_results', {
37+
action_category: 'Benchmark',
38+
action_name: 'clear_results'
3939
});
4040
}
4141
this.clearResults();
@@ -44,8 +44,8 @@ class BrowserBenchmarkRunner {
4444
// Track category selection in Google Analytics
4545
if (typeof gtag === 'function') {
4646
gtag('event', 'select_content', {
47-
event_category: 'Benchmark',
48-
event_label: `Category: ${e.target.value}`
47+
content_type: 'benchmark_category',
48+
category_name: e.target.value
4949
});
5050
}
5151
if (e.target.value !== 'all') {
@@ -66,8 +66,8 @@ class BrowserBenchmarkRunner {
6666
// Track benchmark run in Google Analytics
6767
if (typeof gtag === 'function') {
6868
gtag('event', 'run_benchmark', {
69-
event_category: 'Benchmark',
70-
event_label: category === 'all' ? 'All Categories' : category
69+
benchmark_category: 'Benchmark',
70+
benchmark_name: category === 'all' ? 'all_categories' : category
7171
});
7272
}
7373

sandbox/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,16 @@ <h2>💡 Philosophy</h2>
6363
</div>
6464

6565
<div class="links">
66-
<a href="https://www.npmjs.com/package/luminara" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="gtag('event', 'click', {event_category: 'Navigation', event_label: 'npm Package'});">
66+
<a href="https://www.npmjs.com/package/luminara" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="if(typeof gtag==='function'){gtag('event','link_click',{'link_category':'Navigation','link_name':'npm_package'});}">
6767
📦 npm Package
6868
</a>
69-
<a href="https://github.com/miller-28/luminara" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="gtag('event', 'click', {event_category: 'Navigation', event_label: 'GitHub Repository'});">
69+
<a href="https://github.com/miller-28/luminara" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="if(typeof gtag==='function'){gtag('event','link_click',{'link_category':'Navigation','link_name':'github_repository'});}">
7070
🐙 GitHub Repository
7171
</a>
72-
<a href="https://github.com/miller-28/luminara/blob/master/docs/features/README.md" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="gtag('event', 'click', {event_category: 'Navigation', event_label: 'Documentation'});">
72+
<a href="https://github.com/miller-28/luminara/blob/master/docs/features/README.md" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="if(typeof gtag==='function'){gtag('event','link_click',{'link_category':'Navigation','link_name':'documentation'});}">
7373
📖 Documentation
7474
</a>
75-
<a href="./benchmark/" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="gtag('event', 'click', {event_category: 'Navigation', event_label: 'Performance Benchmarks'});">
75+
<a href="./benchmark/" target="_blank" rel="noopener noreferrer" class="link-btn" onclick="if(typeof gtag==='function'){gtag('event','link_click',{'link_category':'Navigation','link_name':'performance_benchmarks'});}">
7676
⚡ Performance Benchmarks
7777
</a>
7878
</div>

sandbox/main.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ class SandboxUI {
229229
entries.forEach(entry => {
230230
if (entry.isIntersecting && !hasTrackedFeaturesView && typeof gtag === 'function') {
231231
gtag('event', 'view_section', {
232-
event_category: 'Engagement',
233-
event_label: 'Features List'
232+
section_category: 'Engagement',
233+
section_name: 'features_list'
234234
});
235235
hasTrackedFeaturesView = true;
236236
featuresObserver.disconnect(); // Only track once
@@ -434,8 +434,8 @@ class SandboxUI {
434434
// Track example run in Google Analytics
435435
if (typeof gtag === 'function') {
436436
gtag('event', 'run_example', {
437-
event_category: 'Examples',
438-
event_label: example.title
437+
example_category: 'Examples',
438+
example_name: example.title.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase()
439439
});
440440
}
441441

@@ -470,8 +470,8 @@ class SandboxUI {
470470
const feature = examples[featureKey];
471471
if (feature && typeof gtag === 'function') {
472472
gtag('event', 'run_feature_group', {
473-
event_category: 'Examples',
474-
event_label: feature.title
473+
feature_category: 'Examples',
474+
feature_name: feature.title.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase()
475475
});
476476
}
477477

@@ -577,8 +577,8 @@ class FooterScrollTracker {
577577
entries.forEach(entry => {
578578
if (entry.isIntersecting && !hasTrackedFooter && typeof gtag === 'function') {
579579
gtag('event', 'scroll_to_section', {
580-
event_category: 'Engagement',
581-
event_label: 'Footer'
580+
section_category: 'Engagement',
581+
section_name: 'footer'
582582
});
583583
hasTrackedFooter = true;
584584
footerObserver.disconnect(); // Only track once

0 commit comments

Comments
 (0)