feat: update insert logic to consider allow_insert_auto_id property (#494)

* fix(grpc): update insert logic to consider allow_insert_auto_id property

- Add retrieval of allow_insert_auto_id from collection properties
- Modify insertable logic to include allow_insert_auto_id condition
- Enhance Insert API tests to validate behavior with allow_insert_auto_id property

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

* fix test

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

---------

Signed-off-by: ryjiang <jiangruiyi@gmail.com>

Author: shanghaikid

milvus/grpc/Data.ts

@@ -145,12 +145,17 @@ export class Data extends Collection {
       throw collectionInfo;
     }
 
+    // get property allow_insert_auto_id
+    const allowInsertAutoId = collectionInfo.properties.find(
+      p => p.key === 'allow_insert_auto_id'
+    )?.value;
+
     // Tip: The field data sequence needs to be set same as `collectionInfo.schema.fields`.
     const functionOutputFields: string[] = [];
     const fieldMap = new Map<string, _Field>(
       collectionInfo.schema.fields.reduce((acc, v) => {
-        // if autoID is true, ignore the primary key field or if upsert is true
-        const insertable = !v.autoID || upsert;
+        // if autoID is true, ignore the primary key field or if upsert is true or allow_insert_auto_id is true
+        const insertable = !v.autoID || upsert || allowInsertAutoId === 'true';
 
         //  if function field is set, you need to ignore the field value in the data.
         if (v.is_function_output) {

test/grpc/Insert.spec.ts

@@ -252,6 +252,12 @@ describe(`Insert API`, () => {
               },
             ],
           },
+          properties: [
+            {
+              key: 'allow_insert_auto_id',
+              value: 'false',
+            },
+          ],
         } as any);
       });
     };
@@ -271,9 +277,7 @@ describe(`Insert API`, () => {
       await fakeClient.insert(params);
       expect('a').toEqual('b');
     } catch (error) {
-      expect(error.message).toContain(
-        ERROR_REASONS.FIELD_TYPE_IS_NOT_SUPPORT
-      );
+      expect(error.message).toContain(ERROR_REASONS.FIELD_TYPE_IS_NOT_SUPPORT);
     } finally {
       fakeClient.closeConnection();
     }
@@ -496,4 +500,34 @@ describe(`Insert API`, () => {
       expect(error.message).toEqual(ERROR_REASONS.INSERT_CHECK_WRONG_DIM);
     }
   });
+
+  it(`Insert data on autoId field after change allow_insert_auto_id property should success`, async () => {
+    // before should throw error
+    try {
+      await milvusClient.insert({
+        collection_name: COLLECTION_NAME,
+        fields_data: [{ a: 1 }],
+      });
+      expect('a').toEqual('b');
+    } catch (error) {
+      // should throw error
+      expect(error.message).toContain('Insert fail');
+    }
+    await milvusClient.alterCollectionProperties({
+      collection_name: COLLECTION_NAME,
+      properties: {
+        allow_insert_auto_id: 'true',
+      },
+    });
+
+    const dataToInsert = generateInsertData(COLLECTION_NAME_PARAMS.fields, 2);
+    const params: InsertReq = {
+      collection_name: COLLECTION_NAME,
+      partition_name: PARTITION_NAME,
+      fields_data: dataToInsert,
+    };
+
+    const res = await milvusClient.insert(params);
+    expect(res.status.error_code).toEqual(ErrorCode.SUCCESS);
+  });
 });

test/grpc/Upsert.spec.ts

@@ -377,6 +377,12 @@ describe(`Upsert API`, () => {
               },
             ],
           },
+          properties: [
+            {
+              key: 'allow_insert_auto_id',
+              value: 'false',
+            },
+          ],
         } as any);
       });
     };