Merge pull request #83 from kiankamgar/1.x

milwad-dev · web-flow · commit 741542342266 · 2024-02-02T20:08:50.000+03:30
[1.x] Improve repetitive character regex in ValidNationalCard rule
diff --git a/src/Rules/ValidNationalCard.php b/src/Rules/ValidNationalCard.php
@@ -19,10 +19,8 @@ public function passes($attribute, $value)
             return false;
         }
 
-        for ($i = 0; $i < 10; $i++) {
-            if (preg_match('/^'.$i.'{10}$/', $value)) {
-                return false;
-            }
+        if (preg_match('/^(.)\1*$/u', $value)) {
+            return false;
         }
 
         for ($i = 0, $sum = 0; $i < 9; $i++) {

Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,8 @@ public function passes($attribute, $value)`
`19`	`19`	`return false;`
`20`	`20`	`}`
`21`	`21`
`22`		`- for ($i = 0; $i < 10; $i++) {`
`23`		`- if (preg_match('/^'.$i.'{10}$/', $value)) {`
`24`		`- return false;`
`25`		`- }`
	`22`	`+ if (preg_match('/^(.)\1*$/u', $value)) {`
	`23`	`+ return false;`
`26`	`24`	`}`
`27`	`25`
`28`	`26`	`for ($i = 0, $sum = 0; $i < 9; $i++) {`