Hotfix/friday feedback (#3715)

* turn libp2p discovery on by default

now:
    -discovery-port for the libp2p port
    -discovery-keypair instead of -libp2p-keypair (generate command doesn't change)
    -disable-libp2p-discovery to turn it off
    -enable-old-discovery to turn that back on

Discovery keypairs are now comma-separated. It will continue to accept
both syntaxes but the semicolon one is prone to errors in shell scripts
and was definitely a mistake.

* don't include PID in libp2p_helper state dirs

* include peer_id in status

* tweak high connectivity check

* add libp2p_priv_to_pub utility

* include node_addrs_and_ports in status

* typo

* add net2 stub

Author: cmr

src/codanet.go

@@ -66,16 +66,13 @@ func MakeHelper(ctx context.Context, listenOn []ma.Multiaddr, externalAddr ma.Mu
 	logger := logging.Logger("codanet.Helper")
 	dso := dsb.DefaultOptions
 
-	bp := path.Join(statedir, strconv.Itoa(os.Getpid()))
-	os.MkdirAll(bp, 0700)
-
-	ds, err := dsb.NewDatastore(path.Join(statedir, strconv.Itoa(os.Getpid()), "libp2p-peerstore-v0"), &dso)
+	ds, err := dsb.NewDatastore(path.Join(statedir, "libp2p-peerstore-v0"), &dso)
 	if err != nil {
 		return nil, err
 	}
 
 	dsoDht := dsb.DefaultOptions
-	dsDht, err := dsb.NewDatastore(path.Join(statedir, strconv.Itoa(os.Getpid()), "libp2p-dht-v0"), &dsoDht)
+	dsDht, err := dsb.NewDatastore(path.Join(statedir, "libp2p-dht-v0"), &dsoDht)
 	if err != nil {
 		return nil, err
 	}

src/gen_keys/libp2p_priv_to_pub.go

@@ -0,0 +1,27 @@
+package main
+import (
+        crypto "github.com/libp2p/go-libp2p-crypto"
+        b58 "github.com/mr-tron/base58/base58"
+        "os"
+    )
+
+func main() {
+    if len(os.Args) != 2 {
+        println("usage: libp2p-priv-to-pub PRIVKEY_BASE58_STRING");
+    }
+    privk_enc := os.Args[1]
+    privk_raw, err := b58.Decode(privk_enc)
+    if err != nil { panic(err); }
+
+    priv, err := crypto.UnmarshalPrivateKey(privk_raw)
+    if err != nil { panic(err); }
+
+    pub := priv.GetPublic()
+
+    pubk_raw, err := crypto.MarshalPublicKey(pub)
+    if err != nil { panic(err); }
+
+    pubk_enc := b58.Encode(pubk_raw)
+
+    println(pubk_enc)
+}