Merge branch 'master' into add_prephasors

Author: chaithyagr

.github/ISSUE_TEMPLATE/01-bug-report.md

@@ -0,0 +1,25 @@
+---
+name: 🐛 Bug
+about: Report a problem
+labels: 'bug'
+---
+
+## Problem
+
+> A report of the problem you observed.
+
+## Expectation
+
+> A description of what you were expecting to observe instead.
+
+## Suggestion
+
+> Some ideas about how to solve that problem.
+
+## Reproducibility
+
+> Steps to reproduce your observations so we can see the problem too, ideally some minimal code example.
+
+## Additional context
+
+> More context about your project, operating system, hardware or whatever to better understand the issue.

.github/ISSUE_TEMPLATE/02-trajectory-request.md

@@ -0,0 +1,14 @@
+---
+name: 🎇 Trajectory request
+about: Propose a new trajectory for MRI-nufft
+labels: ['trajectories', 'feature request']
+title: "Add trajectory"
+---
+
+## The trajectory
+
+> Describe the trajectory/sampling pattern, don't hesitate to add pictures. 
+
+## References
+
+> Add publication and/or code references.

.github/ISSUE_TEMPLATE/03-installation-trouble.md

@@ -0,0 +1,31 @@
+---
+name: 🛠️ Installation issues
+about: Failed to install MRI-nufft or one of its backend ?
+title: "Installation issue with "
+---
+
+<!-- Please fill out the following sections to help us understand your issue. 
+
+Before submitting, please ensure that you have read the installation guidelines:
+https://mind-inria.github.io/mri-nufft/getting_started.html
+-->
+
+## My System
+
+ - **OS**: [e.g. Ubuntu 20.04, macOS 11.2, Windows 10]
+ - **Python version**: [e.g. 3.8.5]
+ - **CUDA version**: [if applicable, e.g. 11.2]
+ - **package manager** [e.g. pip, uv, conda]
+
+## What I did
+
+> Describe the steps you took to install MRI-nufft or its backend, including any commands you ran.
+
+## What happened
+
+> Describe the error messages or issues you encountered during installation.
+> If possible, include the full output of the installation command.
+
+## Additional context
+
+> Provide any additional information that might help diagnose the issue. 

.github/ISSUE_TEMPLATE/04-feature-request.md

@@ -0,0 +1,14 @@
+---
+name: ✨ Feature request
+about: Suggest a new feature for MRI-nufft
+labels: 'feature request'
+---
+
+## Description & use cases
+
+> Describe the feature you would like to see in MRI-nufft. Be as specific as possible about what you want to achieve.
+
+
+## Suggested implementation
+
+> Describe how you envision the feature being implemented. This could include specific functions, classes, or changes to existing code.

.github/pull_request_template.md

@@ -0,0 +1,25 @@
+<!---
+This is a suggested pull request template for mri-nufft.
+It's designed to capture information we've found to be useful in reviewing pull requests.
+
+If there is other information that would be helpful to include, please don't hesitate to add it!
+
+Please make sure your pull request also follows the
+[contribution guidelines](https://github.com/mind-inria/mri-nufft/blob/master/CONTRIBUTING.md) that
+will be enforced during the review process.
+-->
+
+<!-- Please indicate after the # which issue you're closing with this PR.
+This is helpful for the maintainers AND will magically close the issue when this
+pull request is merged!
+If the PR closes multiple issues, includes "closes" before each one is listed.
+https://help.github.com/articles/closing-issues-using-keywords -->
+- Closes #
+
+<!-- Please give a brief overview of what has changed in the PR.
+If you're not sure what to write, consider it a note to the maintainers to indicate
+what they should be looking for when they review the pull request. -->
+Changes proposed in this pull request:
+
+-
+-

src/mrinufft/trajectories/display3D.py

@@ -101,7 +101,7 @@ def get_gridded_trajectory(
             np.tile(np.linspace(1, 10, trajectory.shape[1]), (trajectory.shape[0],)),
             None,
             True,
-        )
+        ) / (gridded_ones + np.finfo(np.float32).eps)
     elif grid_type == "inversion":
         data = grid_op.raw_op.adj_op(
             np.repeat(
@@ -110,7 +110,7 @@ def get_gridded_trajectory(
             )[: samples.shape[0]],
             None,
             True,
-        )
+        ) / (gridded_ones + np.finfo(np.float32).eps)
     elif grid_type == "holes":
         data = np.abs(gridded_ones).squeeze() < threshold
         if elliptical_samp:
@@ -143,5 +143,5 @@ def get_gridded_trajectory(
             data = np.hstack([slews, np.zeros((slews.shape[0], 2, slews.shape[2]))])
         data = grid_op.raw_op.adj_op(
             np.linalg.norm(data, axis=-1).flatten(), None, True
-        )
+        ) / (gridded_ones + np.finfo(np.float32).eps)
     return np.squeeze(np.abs(data))

src/mrinufft/trajectories/inits/travelling_salesman.py

@@ -30,23 +30,22 @@ def _sort_by_coordinate(array: NDArray, coord: Coordinate) -> NDArray:
             f"Invalid `coord`='{coord}' for arrays with less than 3 dimensions."
         )
 
-    match coord.lower():
-        case "x":
-            coord = array[..., 0]
-        case "y":
-            coord = array[..., 1]
-        case "z":
-            coord = array[..., 2]
-        case "r":
-            coord = np.linalg.norm(array, axis=-1)
-        case "phi":
-            coord = np.sign(array[..., 1]) * np.arccos(
-                array[..., 0] / nl.norm(array[..., :2], axis=-1)
-            )
-        case "theta":
-            coord = np.arccos(array[..., 2] / nl.norm(array, axis=-1))
-        case _:
-            raise ValueError(f"Unknown coordinate `{coord}`")
+    if coord == "x":
+        coord = array[..., 0]
+    elif coord == "y":
+        coord = array[..., 1]
+    elif coord == "z":
+        coord = array[..., 2]
+    elif coord == "r":
+        coord = np.linalg.norm(array, axis=-1)
+    elif coord == "phi":
+        coord = np.sign(array[..., 1]) * np.arccos(
+            array[..., 0] / nl.norm(array[..., :2], axis=-1)
+        )
+    elif coord == "theta":
+        coord = np.arccos(array[..., 2] / nl.norm(array, axis=-1))
+    else:
+        raise ValueError(f"Unknown coordinate `{coord}`")
     order = np.argsort(coord)
     return array[order]