feat(core): Merge pull request #161 from mindfiredigital/dev

release

Author: anandmindfire

packages/angular/dist/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mindfiredigital/page-builder-angular",
-  "version": "4.0.7",
+  "version": "4.0.8",
   "private": true,
   "description": "Angular wrapper for @mindfiredigital/page-builder",
   "main": "dist/index.js",

packages/core/dist/PageBuilder.js

@@ -224,134 +224,12 @@ export class PageBuilder {
       });
     }
   }
-  // public setupExportPDFButton() {
-  //   const exportButton = document.getElementById('export-pdf-btn');
-  //   if (exportButton) {
-  //     exportButton.addEventListener('click', async () => {
-  //       showNotification('Generating PDF for download...');
-  //       await new Promise(resolve => setTimeout(resolve, 1500));
-  //       const tempContainer = document.createElement('div');
-  //       try {
-  //         const worker = html2pdf();
-  //         if (!worker) {
-  //           showNotification('html2pdf library not loaded');
-  //           return;
-  //         }
-  //         const htmlGenerator = new HTMLGenerator(new Canvas());
-  //         const contentHTML = htmlGenerator.generateHTML();
-  //         let css = htmlGenerator.generateCSS();
-  //         const canvasElement = document.getElementById('canvas');
-  //         const sidebarElement = document.getElementById('sidebar');
-  //         if (!canvasElement) return;
-  //         const MARGIN_MM = 4;
-  //         let canvasWidth: number;
-  //         if (PageBuilder.initialCanvasWidth === null) {
-  //           const rect = canvasElement.getBoundingClientRect();
-  //           if (sidebarElement) {
-  //             canvasWidth =
-  //               rect.width + sidebarElement?.getBoundingClientRect().width;
-  //           } else {
-  //             canvasWidth = rect.width;
-  //           }
-  //           PageBuilder.initialCanvasWidth = canvasWidth;
-  //         } else {
-  //           canvasWidth = PageBuilder.initialCanvasWidth;
-  //         }
-  //         css = css.replace(/min-height:\s*100vh/gi, 'min-height: auto');
-  //         const pdfContent = `
-  //           <style>
-  //             ${css}
-  //             * { box-sizing: border-box; }
-  //             html, body, #pdf-wrapper {
-  //               margin: 0; padding: 0;
-  //               overflow: visible !important;
-  //               font-family: Arial, sans-serif !important;
-  //               background-color: white !important;
-  //             }
-  //             /* CRITICAL VERTICAL FIX: Ensure auto height for full expansion */
-  //             #pdf-wrapper {
-  //               width: ${canvasWidth}px !important;
-  //               height: auto !important;
-  //               overflow: visible !important;
-  //               transform: none !important;
-  //             }
-  //             #canvas.home {
-  //               width: ${canvasWidth}px !important;
-  //               height: auto !important;
-  //               min-height: auto !important;
-  //               transform: none !important;
-  //               position: relative !important;
-  //               margin: 0 !important;
-  //               padding: 0 !important;
-  //               overflow: visible !important;
-  //             }
-  //             /* Added for clean page breaking */
-  //             table, #pdf-wrapper, #canvas.home {
-  //               page-break-inside: avoid !important;
-  //             }
-  //           </style>
-  //           <div id="pdf-wrapper">
-  //             ${contentHTML}
-  //           </div>
-  //         `;
-  //         tempContainer.innerHTML = pdfContent;
-  //         tempContainer.style.cssText = `
-  //                   position: absolute;
-  //                   left: -99999px;
-  //                   top: 0;
-  //                   width: ${canvasWidth}px;
-  //                   height: auto;
-  //                   overflow: visible;
-  //                   background-color: white;
-  //               `;
-  //         document.body.appendChild(tempContainer);
-  //         // Give a solid, but shorter, wait time.
-  //         await new Promise(resolve => setTimeout(resolve, 1500));
-  //         const sourceElement = tempContainer.querySelector('#pdf-wrapper') as HTMLElement;
-  //         if (!sourceElement) {
-  //           throw new Error("PDF source element (#pdf-wrapper) not found.");
-  //         }
-  //         await worker
-  //           .set({
-  //             filename: 'exported_page_download.pdf',
-  //             image: { type: 'png', quality: 1 },
-  //             html2canvas: {
-  //               scale: 3,
-  //               width: canvasWidth,
-  //               useCORS: true,
-  //               logging: false,
-  //               backgroundColor: null,
-  //               letterRendering: true,
-  //               allowTaint: true,
-  //             },
-  //             jsPDF: {
-  //               unit: 'mm',
-  //               format: 'a4',
-  //               orientation: 'portrait',
-  //             },
-  //             margin: MARGIN_MM,
-  //           })
-  //           .from(sourceElement)
-  //           .save();
-  //         showNotification('PDF downloaded successfully!');
-  //       } catch (error) {
-  //         console.error('PDF generation error:', error);
-  //         showNotification('Error generating PDF. Check console for details.');
-  //       } finally {
-  //         if (document.body.contains(tempContainer)) {
-  //           document.body.removeChild(tempContainer);
-  //         }
-  //       }
-  //     });
-  //   }
-  // }
   setupExportPDFButton() {
     const exportButton = document.getElementById('export-pdf-btn');
     if (exportButton) {
       exportButton.addEventListener('click', () =>
         __awaiter(this, void 0, void 0, function* () {
           showNotification('Generating PDF for download...');
-          // Note: Keeping this initial delay for stability
           yield new Promise(resolve => setTimeout(resolve, 1500));
           const tempContainer = document.createElement('div');
           try {
@@ -365,21 +243,16 @@ export class PageBuilder {
             let css = htmlGenerator.generateCSS();
             const canvasElement = document.getElementById('canvas');
             if (!canvasElement) return;
-            // 1. GET TRUE CONTENT DIMENSIONS (CRUCIAL FIX)
-            // Use scroll dimensions to get the full size of the content, even if it's off-screen.
             const contentWidth = canvasElement.scrollWidth;
             const contentHeight = canvasElement.scrollHeight;
-            // 2. CALCULATE UNIFIED SHRINK FACTOR
-            const A4_WIDTH_PX = 794; // A4 width at 96 DPI
-            const A4_HEIGHT_PX = 1123; // A4 height at 96 DPI
-            const MARGIN_BUFFER_PX = 40; // Small buffer for margins
+            const A4_WIDTH_PX = 794;
+            const A4_HEIGHT_PX = 1123;
+            const MARGIN_BUFFER_PX = 40;
             const QUALITY_SCALE = 3;
-            // Calculate factor needed to shrink content to fit A4 usable area
             const widthScaleFactor =
               (A4_WIDTH_PX - MARGIN_BUFFER_PX) / contentWidth;
             const heightScaleFactor =
               (A4_HEIGHT_PX - MARGIN_BUFFER_PX) / contentHeight;
-            // Use the smallest factor (width or height) to ensure ALL content fits on one page.
             const SHRINK_FACTOR = Math.min(
               widthScaleFactor,
               heightScaleFactor,

packages/core/src/PageBuilder.ts

@@ -234,7 +234,6 @@ export class PageBuilder {
     if (exportButton) {
       exportButton.addEventListener('click', async () => {
         showNotification('Generating PDF for download...');
-        // Note: Keeping this initial delay for stability
         await new Promise(resolve => setTimeout(resolve, 1500));
 
         const tempContainer = document.createElement('div');