Skip to content

Commit 2549896

Browse files
committed
remove datasource
1 parent 0922300 commit 2549896

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

examples/base_usage.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@
6363
mind = client.minds.get('mind_name')
6464

6565
# removing datasource
66-
# ? should it drop datasource if it is not connected to any mind anymore?
67-
# TODO is not implemented on gateway
6866
mind.del_datasource(datasource)
6967

7068
# remove mind

minds/minds.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,16 @@ def add_datasource(self, datasource: Datasource):
8888
self.datasources = updated.datasources
8989

9090
def del_datasource(self, datasource: Union[Datasource, str]):
91-
raise NotImplementedError
91+
if isinstance(datasource, Datasource):
92+
datasource = datasource.name
93+
elif not isinstance(datasource, str):
94+
raise ValueError(f'Unknown type of datasource: {datasource}')
95+
self.api.delete(
96+
f'/projects/{self.project}/minds/{self.name}/datasources/{datasource}',
97+
)
98+
updated = self.client.minds.get(self.name)
99+
100+
self.datasources = updated.datasources
92101

93102
def completion(self, message):
94103
parsed = urlparse(self.api.base_url)

0 commit comments

Comments
 (0)