removed replace param from datasources.create

Author: ea-rus

minds/datasources/datasources.py

@@ -21,7 +21,7 @@ class Datasources:
     def __init__(self, client):
         self.api = client.api
 
-    def create(self, ds_config: DatabaseConfig, replace=False, update=False):
+    def create(self, ds_config: DatabaseConfig, update=False):
         """
         Create new datasource and return it
 
@@ -31,20 +31,12 @@ def create(self, ds_config: DatabaseConfig, replace=False, update=False):
            - description: str, description of the database. Used by mind to know what data can be got from it.
            - connection_data: dict, optional, credentials to connect to database
            - tables: list of str, optional, list of allowed tables
-        :param replace: if true - to remove existing datasource, default is false
         :param update: if true - to update datasourse if exists, default is false
         :return: datasource object
         """
 
         name = ds_config.name
 
-        if replace:
-            try:
-                self.get(name)
-                self.drop(name, force=True)
-            except exc.ObjectNotFound:
-                ...
-
         if update:
             self.api.put('/datasources', data=ds_config.model_dump())
         else:

tests/integration/test_base_flow.py

@@ -38,8 +38,6 @@ def test_datasources():
     # create
     ds = client.datasources.create(example_ds)
     assert ds.name == example_ds.name
-    ds = client.datasources.create(example_ds, replace=True)
-    assert ds.name == example_ds.name
     ds = client.datasources.create(example_ds, update=True)
     assert ds.name == example_ds.name
 

tests/unit/test_unit.py

@@ -54,13 +54,6 @@ def check_ds_created(ds, mock_post):
 
         check_ds_created(ds, mock_post)
 
-        # with replace
-        ds = client.datasources.create(example_ds, replace=True)
-        args, _ = mock_del.call_args
-        assert args[0].endswith(f'/api/datasources/{example_ds.name}')
-
-        check_ds_created(ds, mock_post)
-
         # with update
         ds = client.datasources.create(example_ds, update=True)
         check_ds_created(ds, mock_put)