prompt_template is mind's param

Author: ea-rus

examples/base_usage.py

@@ -35,14 +35,17 @@
 
 # or separately
 datasource = client.datasources.create(postgres_config)
-mind2 = client.minds.create(name='mind_name', datasources=[datasource] )
+mind = client.minds.create(name='mind_name', datasources=[datasource] )
+
+# with prompt template
+mind = client.minds.create(name='mind_name', prompt_template='You are codding assistant')
 
 # or add to existed mind
-mind3 = client.minds.create(name='mind_name')
+mind = client.minds.create(name='mind_name')
 # by config
-mind2.add_datasource(postgres_config)
+mind.add_datasource(postgres_config)
 # or by datasource
-mind2.add_datasource(datasource)
+mind.add_datasource(datasource)
 
 
 # --- managing minds ---

minds/minds.py

@@ -28,6 +28,9 @@ def __init__(
         self.name = name
         self.model_name = model_name
         self.provider = provider
+        if parameters is None:
+            parameters = {}
+        self.prompt_template = parameters.pop('prompt_template', None)
         self.parameters = parameters
         self.created_at = created_at
         self.updated_at = updated_at
@@ -39,8 +42,9 @@ def update(
         name: str = None,
         model_name: str = None,
         provider=None,
+        prompt_template=None,
+        datasources=None,
         parameters=None,
-        datasources=None
     ):
         data = {}
 
@@ -57,8 +61,13 @@ def update(
             data['model_name'] = model_name
         if provider is not None:
             data['provider'] = provider
-        if parameters is not None:
-            data['parameters'] = parameters
+        if parameters is None:
+            parameters = {}
+
+        data['parameters'] = parameters
+
+        if prompt_template is not None:
+            data['parameters']['prompt_template'] = prompt_template
 
         self.api.patch(
             f'/projects/{self.project}/minds/{self.name}',
@@ -185,8 +194,9 @@ def create(
         self, name,
         model_name=None,
         provider=None,
-        parameters=None,
+        prompt_template=None,
         datasources=None,
+        parameters=None,
         replace=False,
     ) -> Mind:
 
@@ -206,6 +216,9 @@ def create(
 
         if parameters is None:
             parameters = {}
+
+        if prompt_template is not None:
+            parameters['prompt_template'] = prompt_template
         if 'prompt_template' not in parameters:
             parameters['prompt_template'] = DEFAULT_PROMPT_TEMPLATE
 

tests/integration/test_base_flow.py

@@ -88,15 +88,13 @@ def test_minds():
         mind_name,
         replace=True,
         datasources=[ds.name, ds2_cfg],
-        parameters={
-            'prompt_template': prompt1
-        }
+        prompt_template=prompt1
     )
 
     # get
     mind = client.minds.get(mind_name)
     assert len(mind.datasources) == 2
-    assert mind.parameters['prompt_template'] == prompt1
+    assert mind.prompt_template == prompt1
 
     # list
     mind_list = client.minds.list()
@@ -106,17 +104,15 @@ def test_minds():
     mind.update(
         name=mind_name2,
         datasources=[ds.name],
-        parameters={
-            'prompt_template': prompt2
-        }
+        prompt_template=prompt2
     )
     with pytest.raises(ObjectNotFound):
         # this name not exists
         client.minds.get(mind_name)
 
     mind = client.minds.get(mind_name2)
     assert len(mind.datasources) == 1
-    assert mind.parameters['prompt_template'] == prompt2
+    assert mind.prompt_template == prompt2
 
     # add datasource
     mind.add_datasource(ds2_cfg)

tests/unit/test_unit.py

@@ -121,14 +121,14 @@ def test_create(self, mock_del, mock_post, mock_get):
         client = get_client()
 
         mind_name = 'test_mind'
-        parameters = {'prompt_template': 'always agree'}
+        prompt_template = 'always agree'
         datasources = ['my_ds']
         provider = 'openai'
 
         response_mock(mock_get, self.mind_json)
         create_params = {
             'name': mind_name,
-            'parameters': parameters,
+            'prompt_template': prompt_template,
             'datasources': datasources
         }
         mind = client.minds.create(**create_params)
@@ -137,8 +137,9 @@ def check_mind_created(mind, mock_post, create_params):
             args, kwargs = mock_post.call_args
             assert args[0].endswith('/api/projects/mindsdb/minds')
             request = kwargs['json']
-            for k, v in create_params.items():
-                assert request[k] == v
+            for key in ('name', 'datasources', 'provider', 'model_name'),:
+                assert request.get(key) == create_params.get(key)
+            assert create_params.get('prompt_template') == request.get('parameters', {}).get('prompt_template')
 
             self.compare_mind(mind, self.mind_json)
 
@@ -147,7 +148,7 @@ def check_mind_created(mind, mock_post, create_params):
         # with replace
         create_params = {
             'name': mind_name,
-            'parameters': parameters,
+            'prompt_template': prompt_template,
             'provider': provider,
         }
         mind = client.minds.create(replace=True, **create_params)