refactored insert files/web

Author: ea-rus

mindsdb_sdk/connectors/rest_api.py

@@ -399,26 +399,7 @@ def delete_skill(self, project: str, name: str):
 
     # Knowledge Base operations.
     @_try_relogin
-    def insert_files_into_knowledge_base(self, project: str, knowledge_base_name: str, file_names: List[str]):
-        r = self.session.put(
-            self.url + f'/api/projects/{project}/knowledge_bases/{knowledge_base_name}',
-            json={
-                'knowledge_base': {
-                    'files': file_names
-                }
-            }
-        )
-        _raise_for_status(r)
-
-        return r.json()
-
-    @_try_relogin
-    def insert_webpages_into_knowledge_base(self, project: str, knowledge_base_name: str, urls: List[str], crawl_depth: int = 1, filters: List[str] = None):
-        data = {
-            'urls': urls,
-            'crawl_depth': crawl_depth,
-            'filters': [] if filters is None else filters
-        }
+    def insert_into_knowledge_base(self, project: str, knowledge_base_name: str, data):
         r = self.session.put(
             self.url + f'/api/projects/{project}/knowledge_bases/{knowledge_base_name}',
             json={

mindsdb_sdk/knowledge_bases.py

@@ -122,7 +122,11 @@ def insert_files(self, file_paths: List[str]):
         """
         Insert data from file to knowledge base
         """
-        self.api.insert_files_into_knowledge_base(self.project.name, self.name, file_paths)
+        self.api.insert_into_knowledge_base(
+            self.project.name,
+            self.name,
+            data={'files': file_paths}
+        )
 
     def insert_webpages(self, urls: List[str], crawl_depth: int = 1, filters: List[str] = None):
         """
@@ -132,7 +136,15 @@ def insert_webpages(self, urls: List[str], crawl_depth: int = 1, filters: List[s
         :param crawl_depth: How deep to crawl from each base URL. 0 = scrape given URLs only
         :param filters: Include only URLs that match these regex patterns
         """
-        self.api.insert_webpages_into_knowledge_base(self.project.name, self.name, urls, crawl_depth=crawl_depth, filters=filters)
+        self.api.insert_into_knowledge_base(
+            self.project.name,
+            self.name,
+            data={
+                'urls': urls,
+                'crawl_depth': crawl_depth,
+                'filters': [] if filters is None else filters
+            }
+        )
 
     def insert(self, data: Union[pd.DataFrame, Query, dict]):
         """