Include Params in Database GETs

[tmichaeldb]

This is needed for other services with API access to be able to connect to datasources if needed

[entelligence-ai-pr-reviews]

Review Summary

🏷️ Draft Comments (3)

Skipped posting 3 drafted comments based on your review threshold. Feel free to update them here.

mindsdb_sdk/databases.py (3)

35-35: Database.__init__ default argument params: Dict = None is mutable and should default to None to avoid shared state bugs, but the code does not handle the case where params is None before assignment.

Scores:

• Production Impact: 2
• Fix Specificity: 5
• Urgency Impact: 2
• Total Score: 9

Reason for filtering: The total score does not exceed the required threshold of 13 for inclusion under the current filtering rules.

Analysis: While the fix is clear and directly applicable, the actual production impact and urgency are low because the bug only manifests if the caller passes None and the code does not handle it, which is not a common or critical failure mode. The total score is below the required threshold.

---

91-95: _list_databases iterates over all rows to build a dict, but if data is large, this could be optimized by using a dictionary comprehension for better readability and slight performance gain.

Scores:

• Production Impact: 1
• Fix Specificity: 5
• Urgency Impact: 1
• Total Score: 7

Reason for filtering: The comment suggests a minor performance/readability improvement with no significant production impact or urgency. The total score does not meet the required threshold.

Analysis: The suggested change is a minor optimization for readability and slight performance gain, not addressing a critical bug or production issue. The fix is clear, but the impact and urgency are minimal, resulting in a low total score.

---

103-104: The list method unnecessarily creates an intermediate variable databases before returning its values; can be simplified for clarity.

Scores:

• Production Impact: 1
• Fix Specificity: 5
• Urgency Impact: 1
• Total Score: 7

Reason for filtering: The comment addresses a minor code clarity and micro-optimization issue with no significant production impact or urgency. It does not meet the required total score threshold for inclusion.

Analysis: The issue is purely stylistic and does not affect production stability or performance in any meaningful way. The fix is clear, but the urgency and impact are minimal, resulting in a low total score.

---

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
mindsdb_sdk
agents.py	211	56	73%	33, 101, 104, 107, 110, 118, 126, 146, 167, 178, 181, 185, 187, 189, 191, 193, 195, 257, 270, 281, 292, 296–311, 323, 332–336, 343–344, 392, 400–401, 454, 503–504, 507, 514, 535–537, 541–545
databases.py	49	2	96%	118, 146
handlers.py	39	1	97%	77
jobs.py	97	7	93%	40, 52, 80, 84, 146–149
knowledge_bases.py	134	15	89%	66–69, 135, 161, 190, 197, 201–203, 207, 229–233, 243
ml_engines.py	42	3	93%	94, 126, 128
models.py	210	19	91%	109, 140–141, 222, 231, 233, 303, 339, 348, 372, 397, 491, 499, 518, 534, 542, 567, 571, 584
projects.py	63	1	98%	160
query.py	13	1	92%	14
skills.py	53	3	94%	43, 45, 49
tables.py	130	15	88%	140–142, 145, 165, 192, 203–204, 209, 224, 227, 321, 342–347, 356, 376
views.py	37	2	95%	105, 138
mindsdb_sdk/connectors
rest_api.py	255	52	80%	19–29, 35–36, 51, 55, 58–59, 79–81, 102, 105, 112–115, 148–156, 177–178, 213–216, 230–231, 285–290, 294–306
mindsdb_sdk/utils
agents.py	50	4	92%	72, 79–81
mind.py	47	47	0%	1–128
openai.py	85	30	65%	37–40, 83–85, 107, 148–158, 215–216, 234–240, 258–276
table_schema.py	21	21	0%	1–54
TOTAL	1623	279	83%

Tests	Skipped	Failures	Errors	Time
28	0 💤	0 ❌	0 🔥	11.115s ⏱️