fix wrong 'is_quoted' count

Author: StpMax

mindsdb_sql_parser/parser.py

@@ -1823,17 +1823,21 @@ def json_value(self, p):
        'identifier DOT star')
     def identifier(self, p):
         node = p[0]
-        is_quoted = False
         if isinstance(p[2], Star):
             node.parts.append(p[2])
+            node.is_quoted.append(False)
         elif isinstance(p[2], int):
             node.parts.append(str(p[2]))
+            node.is_quoted.append(False)
         elif isinstance(p[2], str):
             node.parts.append(p[2])
+            node.is_quoted.append(False)
+        elif isinstance(p[2], Identifier):
+            node.append(p[2])
         else:
-            node.parts += p[2].parts
-            is_quoted = p[2].is_quoted[0]
-        node.is_quoted.append(is_quoted)
+            # fallback, shouldn't happen
+            node.parts.append(str(p[2]))
+            node.is_quoted.append(False)
         return node
 
     @_('quote_string',

tests/test_base_sql/test_select_structure.py

@@ -714,9 +714,10 @@ def test_backticks(self):
         sql = "SELECT `name`, `status` FROM `mindsdb`.`wow stuff predictors`.`even-dashes-work`.`nice`"
         ast = parse_sql(sql)
 
-        expected_ast = Select(targets=[Identifier(parts=['name']), Identifier(parts=['status'])],
-                              from_table=Identifier(parts=['mindsdb', 'wow stuff predictors', 'even-dashes-work', 'nice']),
-                              )
+        expected_ast = Select(
+            targets=[Identifier('`name`'), Identifier('`status`')],
+            from_table=Identifier('`mindsdb`.`wow stuff predictors`.`even-dashes-work`.`nice`'),
+        )
 
         assert ast.to_tree() == expected_ast.to_tree()
         assert str(ast) == str(expected_ast)

tests/test_mindsdb/test_create_predictor.py

@@ -124,7 +124,7 @@ def test_create_predictor_quotes(self):
         ast = parse_sql(sql)
         expected_ast = CreatePredictor(
             name=Identifier('xxx'),
-            integration_name=Identifier('yyy'),
+            integration_name=Identifier('`yyy`'),
             query_str="SELECT * FROM zzz",
             targets=[Identifier('sss')],
         )