From 78d579c457e1dd69b9d7e35e5b9e9a706761c6c6 Mon Sep 17 00:00:00 2001 From: zimo Date: Thu, 30 Dec 2021 21:31:17 +0800 Subject: [PATCH] env: Linux debian 5.15.0-2 gcc-11.2 cmake-3.22.1 mindspore commit: f9270b8e095df15aa26574a758498316dd307f2f MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit error eg: mindspore/akg/third_party/incubator-tvm/3rdparty/picojson/picojson.h:389:122: error: suggest parentheses around assignment used as truth v alue [-Werror=parentheses] 389 | GET(double, (type_ == int64_type && (const_cast(this)->type_ = number_type, const_cast(this)->u_.number_ = u_.int64_), | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ /home/hyolin/project/mindspore/akg/third_party/incubator-tvm/3rdparty/picojson/picojson.h:377:12: note: in definition of macro ‘GET’ 377 | return var; | ^~~ --- src/poly/dma_inject.cc | 2 +- src/poly/tiling/tiling_strategy_manager_gpu.cc | 4 ++-- src/poly/tiling/tiling_strategy_manager_npu.cc | 2 +- src/poly/tune_info_adapter.cc | 4 ++-- src/schedule/auto_inline.cc | 4 ++-- third_party/incubator-tvm/3rdparty/picojson/picojson.h | 4 ++-- third_party/incubator-tvm/include/tvm/runtime/packed_func.h | 2 +- third_party/incubator-tvm/src/relay/op/tensor/transform.cc | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/poly/dma_inject.cc b/src/poly/dma_inject.cc index 1232ad393..fef0b2314 100644 --- a/src/poly/dma_inject.cc +++ b/src/poly/dma_inject.cc @@ -54,7 +54,7 @@ void ExtractOffsetFromConstraintEx(__isl_keep isl_constraint *c, EqualityInfoMap CHECK(equality_info_map != nullptr); if (!isl_constraint_is_equality(c)) return; - EqualityConstraintInfo info; + EqualityConstraintInfo info{0}; auto val_ptr = isl_constraint_get_constant_val(c); info.offset = static_cast(isl_val_get_num_si(val_ptr)); static_cast(isl_val_free(val_ptr)); diff --git a/src/poly/tiling/tiling_strategy_manager_gpu.cc b/src/poly/tiling/tiling_strategy_manager_gpu.cc index 16371eddc..f5e91d9d5 100755 --- a/src/poly/tiling/tiling_strategy_manager_gpu.cc +++ b/src/poly/tiling/tiling_strategy_manager_gpu.cc @@ -713,7 +713,7 @@ void GpuStrategy::ApplyCustomConstraint() { // add constraints to binding space according to custom tiling std::unordered_set thread_keys = {AT_THREAD_MIN, AT_THREAD_MAX, AT_THREAD_MOD}; std::unordered_set block_keys = {AT_BLOCK_MIN, AT_BLOCK_MAX, AT_BLOCK_MOD}; - for (const auto attr : analyzer_->RootAxis()->attrs) { + for (const auto &attr : analyzer_->RootAxis()->attrs) { std::vector constraint; std::vector target; if (thread_keys.find(attr.attr_key) != thread_keys.end()) { @@ -1756,7 +1756,7 @@ void GpuStrategy::AnalyzeBroadcastIdx() { continue; } auto op_types = common::Split(attr.attr_key, "_"); - for (const auto type : op_types) { + for (const auto &type : op_types) { if (type.find(AT_BROADCAST) == std::string::npos) { continue; } diff --git a/src/poly/tiling/tiling_strategy_manager_npu.cc b/src/poly/tiling/tiling_strategy_manager_npu.cc index a7fc51e9d..f13c4668e 100644 --- a/src/poly/tiling/tiling_strategy_manager_npu.cc +++ b/src/poly/tiling/tiling_strategy_manager_npu.cc @@ -223,7 +223,7 @@ void DmaAlignStrategy::AddNpuConstraint() { } for (auto axis : analyzer_->GetAxesOfAttr(AT_BROADCAST_INNERMOST_AXIS)) { - for (const auto attr : axis->attrs) { + for (const auto &attr : axis->attrs) { if (attr.attr_key != AT_BROADCAST_INNERMOST_AXIS) { continue; } diff --git a/src/poly/tune_info_adapter.cc b/src/poly/tune_info_adapter.cc index 77a04748d..e61311ad0 100644 --- a/src/poly/tune_info_adapter.cc +++ b/src/poly/tune_info_adapter.cc @@ -55,7 +55,7 @@ TuneAxisInfo AxisInfoAdapter(TileAxis *a, TileSizes dims) { if (axis_info->dims.empty()) { axis_info->dims.push_back(MIN_TILE); } - for (const auto attr : a->attrs) { + for (const auto &attr : a->attrs) { if (axis_info->attrs.find(attr.attr_key) != axis_info->attrs.end()) { axis_info->attrs[attr.attr_key].push_back(attr.attr_value); } else { @@ -120,7 +120,7 @@ std::unique_ptr AdaptTuneInfo(const TilingAnalyzer &analyzer, ScopInfo tune_info->analysis.Set("op_template", StringImm::make(t[0])); } auto axis_info = make_node(); - for (const auto attr : a->attrs) { + for (const auto &attr : a->attrs) { if (axis_info->attrs.find(attr.attr_key) != axis_info->attrs.end()) { axis_info->attrs[attr.attr_key].push_back(attr.attr_value); } else { diff --git a/src/schedule/auto_inline.cc b/src/schedule/auto_inline.cc index cd50b6fcf..c5bff6320 100644 --- a/src/schedule/auto_inline.cc +++ b/src/schedule/auto_inline.cc @@ -137,13 +137,13 @@ class CSE { for (const auto op : sch->outputs) { count_used_number(op); } - for (const auto op : counter) { + for (const auto &op : counter) { if (op.second > 1) { RemoveShortCommonExpr(op.first, op.first); } } std::unordered_set common_op; - for (const auto op : counter) { + for (const auto &op : counter) { int input_num = 0; input_num = count_input_number(op.first, input_num); if (op.first.as() != nullptr && op.second > 1 && input_num > 2) { diff --git a/third_party/incubator-tvm/3rdparty/picojson/picojson.h b/third_party/incubator-tvm/3rdparty/picojson/picojson.h index 5b5d2fbca..1a2b4ea1c 100644 --- a/third_party/incubator-tvm/3rdparty/picojson/picojson.h +++ b/third_party/incubator-tvm/3rdparty/picojson/picojson.h @@ -386,8 +386,8 @@ GET(std::string, *u_.string_) GET(array, *u_.array_) GET(object, *u_.object_) #ifdef PICOJSON_USE_INT64 -GET(double, (type_ == int64_type && (const_cast(this)->type_ = number_type, - const_cast(this)->u_.number_ = u_.int64_), +GET(double, (type_ == int64_type && ((const_cast(this)->type_ = number_type), + (const_cast(this)->u_.number_ = u_.int64_)), u_.number_)) GET(int64_t, u_.int64_) #else diff --git a/third_party/incubator-tvm/include/tvm/runtime/packed_func.h b/third_party/incubator-tvm/include/tvm/runtime/packed_func.h index 37e948796..b911a46d2 100644 --- a/third_party/incubator-tvm/include/tvm/runtime/packed_func.h +++ b/third_party/incubator-tvm/include/tvm/runtime/packed_func.h @@ -543,7 +543,7 @@ class TVMPODValue_ { protected: friend class TVMArgsSetter; friend class TVMRetValue; - TVMPODValue_() : type_code_(kNull) {} + TVMPODValue_() : type_code_(kNull) {value_.v_handle = nullptr;} TVMPODValue_(TVMValue value, int type_code) : value_(value), type_code_(type_code) {} diff --git a/third_party/incubator-tvm/src/relay/op/tensor/transform.cc b/third_party/incubator-tvm/src/relay/op/tensor/transform.cc index 033fc4d3b..853351eb8 100644 --- a/third_party/incubator-tvm/src/relay/op/tensor/transform.cc +++ b/third_party/incubator-tvm/src/relay/op/tensor/transform.cc @@ -1655,7 +1655,7 @@ bool SqueezeRel(const Array& types, CHECK_LT(axis_val, original_shape.size()); original_shape.at(axis_val).second = false; } - for (const auto p : original_shape) { + for (const auto &p : original_shape) { if (p.second) { result_shape.push_back(p.first); } else {