clean code (#1185)

Co-authored-by: qiuyufeng <[email protected]>

Author: QYuFong

examples/opensora_hpcai/opensora/models/vae/vae.py

@@ -252,12 +252,14 @@ def build_module_from_config(config):
         - type: model class name
         - others: model init args
     """
+    supported_model = {"VideoAutoencoderKL": VideoAutoencoderKL, "VAE_Temporal_SD": VAE_Temporal_SD}
     cfg = config.copy()
     name = cfg.pop("type")
     kwargs = cfg
-
+    if name not in supported_model:
+        raise ValueError(f"Get unsupported model type {name}")
     # FIXME: use importlib with path
-    module = eval(name)(**kwargs)
+    module = supported_model[name](**kwargs)
     return module
 
 

examples/step_video_t2v/api/call_remote_server.py

@@ -5,7 +5,6 @@
 import argparse
 import ast
 import os
-import pickle
 import threading
 
 from flask import Blueprint, Flask, Response, request
@@ -91,14 +90,20 @@ def get(self):
             #         print("Caught Exception: ", e)
             #         return Response(e)
 
-            feature = pickle.loads(request.get_data())
-            feature["api"] = "vae"
-
-            feature = {k: v for k, v in feature.items() if v is not None}
-            video_latents = self.vae_pipeline.decode(**feature)
-
-            response = pickle.dumps(video_latents)
-
+            print(
+                "Using pickle to transfer data may bring security risks. "
+                "Please confirm the security risks before using this API."
+                "You can remove the comment markers of L99 ~ L104 and "
+                "add a comment marker at L105 ~ L106 to re-enable the code."
+            )
+            # import pickle
+            # feature = pickle.loads(request.get_data())
+            # feature["api"] = "vae"
+            # feature = {k: v for k, v in feature.items() if v is not None}
+            # video_latents = self.vae_pipeline.decode(**feature)
+            # response = pickle.dumps(video_latents)
+            feature = request.get_data()
+            response = feature
             return Response(response)
 
 
@@ -164,13 +169,20 @@ def get(self):
             #     print("Caught Exception: ", e)
             #     return Response(e)
 
-            feature = pickle.loads(request.get_data())
-            feature["api"] = "caption"
-
-            feature = {k: v for k, v in feature.items() if v is not None}
-            embeddings = self.caption_pipeline.embedding(**feature)
-            response = pickle.dumps(embeddings)
-
+            print(
+                "Using pickle to transfer data may bring security risks. "
+                "Please confirm the security risks before using this API."
+                "You can remove the comment markers of L178 ~ L183 and "
+                "add a comment marker at L184 ~ L185 to re-enable the code."
+            )
+            # import pickle
+            # feature = pickle.loads(request.get_data())
+            # feature["api"] = "caption"
+            # feature = {k: v for k, v in feature.items() if v is not None}
+            # embeddings = self.caption_pipeline.embedding(**feature)
+            # response = pickle.dumps(embeddings)
+            feature = request.get_data()
+            response = feature
             return Response(response)
 
 

tools/t2v_curation/pipeline/splitting/cut.py

@@ -1,4 +1,6 @@
 import argparse
+import ast
+import json
 import os
 import subprocess
 from functools import partial
@@ -28,7 +30,10 @@ def process_single_row(row, args):
             timestamp = row["timestamp"]
             if not (timestamp.startswith("[") and timestamp.endswith("]")):
                 return False
-            scene_list = eval(timestamp)
+            try:
+                scene_list = json.loads(timestamp)
+            except json.JSONDecodeError:
+                scene_list = ast.literal_eval(timestamp)
             scene_list = [(FrameTimecode(s, fps=100), FrameTimecode(t, fps=100)) for s, t in scene_list]
         else:
             scene_list = [None]