feat(DynamicExcelColumn): make the CustomFormatter property more powerful #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shps951023
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #708
我注意到，在此前的PR #700 中，DynamicExcelColumn增加了一个属性：
PR #700 存在一些问题，假设我原来的值是数字类型，因为这里返回的值是string类型，并且因为调用CustomFormatter委托时机问题，导致最终生成的Excel单元格设置是数字但实际值非数字，Excel打开报错，例如，我想对金额加一个币别符号1 -> $1
我进行了一些优化，调整为
Func<object, object>，可以避免此问题