refactor(rewrite): avoid string concatenation in a loop (perfsprint linter fix)

jvoisin · web-flow · commit 093004b724f1 · 2025-11-04T16:59:46.000-08:00
diff --git a/internal/reader/rewrite/content_rewrite_functions.go b/internal/reader/rewrite/content_rewrite_functions.go
@@ -315,13 +315,14 @@ func addYoutubeVideoFromId(entryContent string) string {
 	if matches == nil {
 		return entryContent
 	}
-	videoPlayerHTML := ""
+	var videoPlayerHTML strings.Builder
 	for _, match := range matches {
 		if len(match) == 2 {
-			videoPlayerHTML += buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride()+match[1]) + "<br>"
+			videoPlayerHTML.WriteString(buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride() + match[1]))
+			videoPlayerHTML.WriteString("<br>")
 		}
 	}
-	return videoPlayerHTML + entryContent
+	return videoPlayerHTML.String() + entryContent
 }
 
 func addInvidiousVideo(entryURL, entryContent string) string {

Original file line number	Diff line number	Diff line change
`@@ -315,13 +315,14 @@ func addYoutubeVideoFromId(entryContent string) string {`
`315`	`315`	`if matches == nil {`
`316`	`316`	`return entryContent`
`317`	`317`	`}`
`318`		`- videoPlayerHTML := ""`
	`318`	`+ var videoPlayerHTML strings.Builder`
`319`	`319`	`for _, match := range matches {`
`320`	`320`	`if len(match) == 2 {`
`321`		`- videoPlayerHTML += buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride()+match[1]) + "<br>"`
	`321`	`+ videoPlayerHTML.WriteString(buildVideoPlayerIframe(config.Opts.YouTubeEmbedUrlOverride() + match[1]))`
	`322`	`+ videoPlayerHTML.WriteString("<br>")`
`322`	`323`	`}`
`323`	`324`	`}`
`324`		`- return videoPlayerHTML + entryContent`
	`325`	`+ return videoPlayerHTML.String() + entryContent`
`325`	`326`	`}`
`326`	`327`
`327`	`328`	`func addInvidiousVideo(entryURL, entryContent string) string {`