Skip to content

Commit 590adb9

Browse files
committed
refactor(googlereader): remove output param check for user-info handler
The `output` parameter seems to be optional and Miniflux will always returns a JSON response. This change makes Miniflux more consistent with other open source RSS readers.
1 parent 9e817e6 commit 590adb9

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

internal/googlereader/handler.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,16 +1000,16 @@ func (h *handler) userInfoHandler(w http.ResponseWriter, r *http.Request) {
10001000
slog.String("user_agent", r.UserAgent()),
10011001
)
10021002

1003-
if err := checkOutputFormat(r); err != nil {
1004-
json.BadRequest(w, r, err)
1005-
return
1006-
}
1007-
10081003
user, err := h.store.UserByID(request.UserID(r))
10091004
if err != nil {
10101005
json.ServerError(w, r, err)
10111006
return
10121007
}
1008+
if user == nil {
1009+
json.NotFound(w, r)
1010+
return
1011+
}
1012+
10131013
userInfo := userInfoResponse{UserID: strconv.FormatInt(user.ID, 10), UserName: user.Username, UserProfileID: strconv.FormatInt(user.ID, 10), UserEmail: user.Username}
10141014
json.OK(w, r, userInfo)
10151015
}

0 commit comments

Comments
 (0)