Skip to content

Commit d862f79

Browse files
jvoisinfguillot
authored andcommitted
refactor(fever): explicitly size slices
1 parent 1bea41b commit d862f79

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

internal/fever/handler.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func (h *handler) handleFeeds(w http.ResponseWriter, r *http.Request) {
143143
}
144144

145145
var result feedsResponse
146-
result.Feeds = make([]feed, 0)
146+
result.Feeds = make([]feed, 0, len(feeds))
147147
for _, f := range feeds {
148148
subscription := feed{
149149
ID: f.ID,
@@ -307,7 +307,7 @@ func (h *handler) handleItems(w http.ResponseWriter, r *http.Request) {
307307
return
308308
}
309309

310-
result.Items = make([]item, 0)
310+
result.Items = make([]item, 0, len(entries))
311311
for _, entry := range entries {
312312
isRead := 0
313313
if entry.Status == model.EntryStatusRead {
@@ -358,7 +358,7 @@ func (h *handler) handleUnreadItems(w http.ResponseWriter, r *http.Request) {
358358
return
359359
}
360360

361-
var itemIDs []string
361+
itemIDs := make([]string, 0, len(rawEntryIDs))
362362
for _, entryID := range rawEntryIDs {
363363
itemIDs = append(itemIDs, strconv.FormatInt(entryID, 10))
364364
}
@@ -392,7 +392,7 @@ func (h *handler) handleSavedItems(w http.ResponseWriter, r *http.Request) {
392392
return
393393
}
394394

395-
var itemsIDs []string
395+
itemsIDs := make([]string, 0, len(entryIDs))
396396
for _, entryID := range entryIDs {
397397
itemsIDs = append(itemsIDs, strconv.FormatInt(entryID, 10))
398398
}
@@ -568,12 +568,12 @@ A feeds_group object has the following members:
568568
feed_ids (string/comma-separated list of positive integers)
569569
*/
570570
func (h *handler) buildFeedGroups(feeds model.Feeds) []feedsGroups {
571-
feedsGroupedByCategory := make(map[int64][]string)
571+
feedsGroupedByCategory := make(map[int64][]string, len(feeds))
572572
for _, feed := range feeds {
573573
feedsGroupedByCategory[feed.Category.ID] = append(feedsGroupedByCategory[feed.Category.ID], strconv.FormatInt(feed.ID, 10))
574574
}
575575

576-
result := make([]feedsGroups, 0)
576+
result := make([]feedsGroups, 0, len(feedsGroupedByCategory))
577577
for categoryID, feedIDs := range feedsGroupedByCategory {
578578
result = append(result, feedsGroups{
579579
GroupID: categoryID,

0 commit comments

Comments
 (0)