warning cleanup 1

Author: minimapletinytools

TODO.txt

@@ -276,25 +276,8 @@ DONE-handlers should return preview action
 -update tutorial file?
 -should be more intuitive to get a 1 sided line
 -opening file with hidden elements does not hide stuff..
-DONE-hide stuff
-  -moving an element into a hidden folder does not hide it right away (ignore this for release)
-    -this is becaues it gets added to superowlchanges
-  -moving a hidden folder (in folder hierarchy) shows it (maybe cuz it's selected ,but it does'nt look selected?? and also deselecitng doesn't hide it)
-    -this is becaues it gets added to superowlchanges
-DONE-layers improvements
-  DONE-when dragging into a folder, the | should then L to the element being moved
-  DONE-currently not possible to drag the last element in folder outside of that folder if there's something below it
-    -the trick is if you drag the last element in a folder to the spot below it, you need exception case to move it outside of the folder rather than as the next sibling to itself since that doesn't do anything
-  DONE-currently not possible to drag below a folder if the folder is thet last sibling :(
-    -not sure if there's a way around this :(
-  DONE-DO THIS you might want to consider doing the thing where dragging to the right side of a folder puts it underneath, otherwise it's always a SiblingPosition
-  DONE-selecting multiple items in layers and click on on should select that one item, but right now it gose into rename mode
-DONE/IGNORE-BUG translating lines should translate midpoints too
-DONE-text box option that auto goes into edit text box
-
 
 ::NEWEST TODO::
-DONE-render testing utilities 
 -layers improvements
   -shift select in layers please ;__;
   -selecting multiple items and hitting new folder should put those items in folder maybe
@@ -432,6 +415,22 @@ DONE-render testing utilities
   -you need some kind of options object to go along side of _setPotatoDefaultParameters_sBoxType
 
 
+DONE-hide stuff
+  -moving an element into a hidden folder does not hide it right away (ignore this for release)
+    -this is becaues it gets added to superowlchanges
+  -moving a hidden folder (in folder hierarchy) shows it (maybe cuz it's selected ,but it does'nt look selected?? and also deselecitng doesn't hide it)
+    -this is becaues it gets added to superowlchanges
+DONE-layers improvements
+  DONE-when dragging into a folder, the | should then L to the element being moved
+  DONE-currently not possible to drag the last element in folder outside of that folder if there's something below it
+    -the trick is if you drag the last element in a folder to the spot below it, you need exception case to move it outside of the folder rather than as the next sibling to itself since that doesn't do anything
+  DONE-currently not possible to drag below a folder if the folder is thet last sibling :(
+    -not sure if there's a way around this :(
+  DONE-DO THIS you might want to consider doing the thing where dragging to the right side of a folder puts it underneath, otherwise it's always a SiblingPosition
+  DONE-selecting multiple items in layers and click on on should select that one item, but right now it gose into rename mode
+DONE/IGNORE-BUG translating lines should translate midpoints too
+DONE-text box option that auto goes into edit text box
+DONE-render testing utilities 
 DONE-empty text zipper should return '' span with cursor 
   -without this, empty cells don't show the cursor...
     -NO this is not the issue :()

src/Potato/Flow/Owl.hs

@@ -122,6 +122,7 @@ instance HasOwlItem SuperOwl where
 
 type SuperOwlChanges = REltIdMap (Maybe SuperOwl)
 
+
 instance PotatoShow SuperOwlChanges where
   potatoShow = (<>) "SuperOwlChanges:\n" . foldr (\msowl acc -> maybe "Nothing" potatoShow msowl <> "\n" <> acc) ""
 

src/Potato/Flow/Types.hs

@@ -67,6 +67,7 @@ import qualified Text.Show
 
 
 
+
 type LayerPos = Int
 type REltIdMap a = IM.IntMap a
 type SuperSEltLabel = (REltId, LayerPos, SEltLabel)

test/Potato/Flow/AttachmentsSpec.hs

@@ -9,8 +9,6 @@ import           Relude           hiding (empty, fromList)
 import           Test.Hspec
 
 import           Potato.Flow.Attachments
-import Potato.Flow.Methods.LineDrawer
-import Potato.Flow.Methods.LineTypes
 import           Potato.Flow.Math
 import Potato.Flow.Serialization.Snake
 

test/Potato/Flow/Controller/GeneralSpec.hs

@@ -15,10 +15,6 @@ import           Potato.Flow.GoatTester
 import           Potato.Flow
 import           Potato.Flow.Controller.Manipulator.TestHelpers
 
-import qualified Data.List                                      as L
-import qualified Data.Sequence                                  as Seq
-import Data.Default
-
 verifyHasUnsavedChanges :: Bool -> GoatTester ()
 verifyHasUnsavedChanges b = do
   gs <- getGoatState

test/Potato/Flow/Controller/Manipulator/BoxSpec.hs

@@ -13,7 +13,6 @@ import           Test.Hspec
 import           Potato.Flow.GoatTester
 
 import           Potato.Flow
-import           Potato.Flow.Common
 import           Potato.Flow.Controller.Manipulator.TestHelpers
 
 

test/Potato/Flow/Controller/Manipulator/LayersSpec.hs

@@ -11,13 +11,11 @@ import           Relude                                         hiding (empty,
 import           Test.Hspec
 
 import           Potato.Flow.GoatTester
-
 import           Potato.Flow
 import           Potato.Flow.Controller.Manipulator.TestHelpers
 
-import qualified Data.List                                      as L
 import qualified Data.Sequence as Seq
-import Control.Monad (forM_)
+
 
 
 someFolderName :: Text

test/Potato/Flow/Controller/Manipulator/TestHelpers.hs

@@ -16,7 +16,7 @@ drawCanvasBox (x, y, sx, sy) = do
   let
     f sowl = case _superOwl_elt sowl of
       OwlItem _ (OwlSubItemBox _) -> Nothing
-      x                           -> Just ("expected box, got " <> show x)
+      xx                           -> Just ("expected box, got " <> show xx)
   verifySelectionIsAndOnlyIs "box is selected" f
 
 

test/Potato/Flow/Deprecated/Controller/EverythingWidgetSpec.hs

@@ -284,26 +284,6 @@ everything_keyboard_test = constructTest "keyboard" owlpfstate_basic1 bs expecte
 
     ]
 
--- TODO FINISH
-everything_newfolder_test :: Test
-everything_newfolder_test = constructTest "new folder" owlpfstate_basic1 bs expected where
-  bs = [
-      EWCLabel "New Folder (no selection)"
-      , EWCNewFolder
-
-      , EWCLabel "New Folder (with selection)"
-      -- TODO open up some folder, and select some stuff
-      --, EWCNewFolder
-    ]
-  expected = [
-      LabelCheck "New Folder (no selection)"
-      , firstSelectedSuperOwlPredicate (Just "<folder>") (\sowl -> case hasOwlItem_toSElt_hack sowl of
-        SEltFolderStart -> True
-        _                                        -> False)
-
-      , LabelCheck "New Folder (with selection)"
-    ]
-
 moveOffset :: Int
 moveOffset = 100
 

test/Potato/Flow/GoatTester.hs

@@ -414,4 +414,4 @@ debugFailWithRenderedCanvas = do
   gs <- getGoatState
   let
     canvas = _goatState_renderedCanvas gs
-  putRecord "debugFailWithRenderedCanvas" (traceShow (renderedCanvas_box canvas) $ Just $ renderedCanvasToText canvas)
+  putRecord "debugFailWithRenderedCanvas" (Just $ renderedCanvasToText canvas)