Remove unused healthz port from controller and fix port placement in DaemonSets (#1015)

- Remove port 9898 from controller container in Deployments (unused)
- Move port 9898 definition to liveness-probe container in DaemonSets
where it actually listens

Co-authored-by: Praveenrajmani <[email protected]>

Author: Praveenrajmani

resources/base/DaemonSet.yaml

@@ -80,9 +80,6 @@ spec:
         - containerPort: 30443
           name: readinessport
           protocol: TCP
-        - containerPort: 9898
-          name: healthz
-          protocol: TCP
         - containerPort: 10443
           name: metrics
           protocol: TCP
@@ -176,6 +173,10 @@ spec:
         - --health-port=9898
         image: quay.io/minio/livenessprobe@sha256:8f3b1bec9c87a832a3fe6e8b7f165e0ff048aef7373f9764f40efee456a00321
         name: liveness-probe
+        ports:
+        - containerPort: 9898
+          name: healthz
+          protocol: TCP
         resources: {}
         terminationMessagePath: /var/log/driver-liveness-termination-log
         terminationMessagePolicy: FallbackToLogsOnError

resources/base/Deployment.yaml

@@ -91,9 +91,6 @@ spec:
         - containerPort: 30443
           name: readinessport
           protocol: TCP
-        - containerPort: 9898
-          name: healthz
-          protocol: TCP
         readinessProbe:
           failureThreshold: 5
           httpGet:

resources/legacy/DaemonSet.yaml

@@ -75,9 +75,6 @@ spec:
         - containerPort: 30443
           name: readinessport
           protocol: TCP
-        - containerPort: 9898
-          name: healthz
-          protocol: TCP
         - containerPort: 10443
           name: metrics
           protocol: TCP
@@ -127,6 +124,10 @@ spec:
         - --health-port=9898
         image: quay.io/minio/livenessprobe@sha256:8f3b1bec9c87a832a3fe6e8b7f165e0ff048aef7373f9764f40efee456a00321
         name: liveness-probe
+        ports:
+        - containerPort: 9898
+          name: healthz
+          protocol: TCP
         resources: {}
         terminationMessagePath: /var/log/driver-liveness-termination-log
         terminationMessagePolicy: FallbackToLogsOnError

resources/legacy/Deployment.yaml

@@ -88,9 +88,6 @@ spec:
         - containerPort: 30443
           name: readinessport
           protocol: TCP
-        - containerPort: 9898
-          name: healthz
-          protocol: TCP
         readinessProbe:
           failureThreshold: 5
           httpGet: