Use SYS as user for deletes from sync (#256)

Author: anthony-britton-moj

src/main/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/sync/internal/SyncTapAuthorisation.kt

@@ -5,6 +5,7 @@ import org.springframework.data.repository.findByIdOrNull
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext
+import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext.Companion.SYSTEM_USERNAME
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.set
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.IdGenerator.newUuid
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.person.PersonSummary
@@ -68,6 +69,7 @@ class SyncTapAuthorisation(
   }
 
   fun deleteById(id: UUID) {
+    ExternalMovementContext.get().copy(username = SYSTEM_USERNAME).set()
     authorisationRepository.findByIdOrNull(id)?.also { authorisation ->
       val occurrenceCount = occurrenceRepository.countByAuthorisationId(authorisation.id)
       if (occurrenceCount > 0) {

src/main/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/sync/internal/SyncTapMovement.kt

@@ -4,6 +4,7 @@ import org.springframework.data.repository.findByIdOrNull
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext
+import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext.Companion.SYSTEM_USERNAME
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.set
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.IdGenerator.newUuid
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.person.PersonSummary
@@ -73,6 +74,7 @@ class SyncTapMovement(
   }
 
   fun deleteById(id: UUID) {
+    ExternalMovementContext.get().copy(username = SYSTEM_USERNAME).set()
     movementRepository.findByIdOrNull(id)?.also {
       it.occurrence?.removeMovement(it) { statusCode -> occurrenceStatusRepository.getByCode(statusCode) }
       movementRepository.delete(it)

src/main/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/sync/internal/SyncTapOccurrence.kt

@@ -5,6 +5,7 @@ import org.springframework.data.repository.findByIdOrNull
 import org.springframework.stereotype.Service
 import org.springframework.transaction.annotation.Transactional
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext
+import uk.gov.justice.digital.hmpps.externalmovementsapi.context.ExternalMovementContext.Companion.SYSTEM_USERNAME
 import uk.gov.justice.digital.hmpps.externalmovementsapi.context.set
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.IdGenerator.newUuid
 import uk.gov.justice.digital.hmpps.externalmovementsapi.domain.referencedata.ReferenceDataDomain.Code.ABSENCE_REASON_CATEGORY
@@ -83,6 +84,7 @@ class SyncTapOccurrence(
   }
 
   fun deleteById(id: UUID) {
+    ExternalMovementContext.get().copy(username = SYSTEM_USERNAME).set()
     occurrenceRepository.findByIdOrNull(id)?.also { occurrence ->
       val movementCount = movementRepository.countByOccurrenceId(occurrence.id)
       if (movementCount > 0) {

src/test/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/integration/sync/DeleteTapAuthorisationIntTest.kt

@@ -71,7 +71,7 @@ class DeleteTapAuthorisationIntTest(
       auth,
       RevisionType.DEL,
       setOf(TemporaryAbsenceAuthorisation::class.simpleName!!),
-      ExternalMovementContext.get().copy(source = DataSource.NOMIS),
+      ExternalMovementContext.get().copy(username = SYSTEM_USERNAME, source = DataSource.NOMIS),
     )
 
     verifyEvents(auth, setOf())

src/test/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/integration/sync/DeleteTapMovementIntTest.kt

@@ -71,14 +71,14 @@ class DeleteTapMovementIntTest(
       movement,
       RevisionType.DEL,
       setOf(TemporaryAbsenceMovement::class.simpleName!!, TemporaryAbsenceOccurrence::class.simpleName!!),
-      ExternalMovementContext.get().copy(source = DataSource.NOMIS),
+      ExternalMovementContext.get().copy(username = SYSTEM_USERNAME, source = DataSource.NOMIS),
     )
 
     verifyAudit(
       occurrence,
       RevisionType.MOD,
       setOf(TemporaryAbsenceMovement::class.simpleName!!, TemporaryAbsenceOccurrence::class.simpleName!!),
-      ExternalMovementContext.get().copy(source = DataSource.NOMIS),
+      ExternalMovementContext.get().copy(username = SYSTEM_USERNAME, source = DataSource.NOMIS),
     )
 
     verifyEvents(movement, setOf())

src/test/kotlin/uk/gov/justice/digital/hmpps/externalmovementsapi/integration/sync/DeleteTapOccurrenceIntTest.kt

@@ -88,7 +88,7 @@ class DeleteTapOccurrenceIntTest(
       occurrence,
       RevisionType.DEL,
       setOf(TemporaryAbsenceOccurrence::class.simpleName!!, TemporaryAbsenceAuthorisation::class.simpleName!!),
-      ExternalMovementContext.get().copy(source = DataSource.NOMIS),
+      ExternalMovementContext.get().copy(username = SYSTEM_USERNAME, source = DataSource.NOMIS),
     )
 
     verifyEvents(occurrence, setOf())