fix(crypto): correctly encode EC signature by padding nums to 32 (#143)

Author: Stupremee

.config/nextest.toml

@@ -43,16 +43,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install ${{ matrix.toolchain }}
         uses: dtolnay/rust-toolchain@master
         with:
@@ -69,16 +63,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install nightly
         uses: dtolnay/rust-toolchain@nightly
       - name: cargo doc
@@ -111,16 +99,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install stable
         uses: dtolnay/rust-toolchain@stable
       - name: cargo install cargo-hack
@@ -148,16 +130,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install ${{ matrix.msrv }}
         uses: dtolnay/rust-toolchain@master
         with:

.github/workflows/check.yml

@@ -21,16 +21,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install nightly
         uses: dtolnay/rust-toolchain@nightly
       - name: cargo install cargo-hack

.github/workflows/scheduled.yml

@@ -24,16 +24,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install ${{ matrix.toolchain }}
         uses: dtolnay/rust-toolchain@master
         with:
@@ -101,16 +95,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install stable
         uses: dtolnay/rust-toolchain@stable
       - name: cargo generate-lockfile
@@ -129,16 +117,10 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: cargo cache
-        uses: actions/cache@v4
-        continue-on-error: false
+      - name: rust cache
+        uses: Swatinem/rust-cache@v2
         with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target/
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
-          restore-keys: ${{ runner.os }}-cargo-
+          shared-key: "jose" # we share cache across jobs
       - name: Install stable
         uses: dtolnay/rust-toolchain@stable
         with:

.github/workflows/test.yml

@@ -151,8 +151,8 @@ impl ec::PrivateKey for PrivateKey {
         // the returned signature is in DER format, we need to convert it according
         // to Section 3.4 of RFC 7518
         let signature = EcdsaSig::from_der(&der_sig)?;
-        let r = signature.r().to_vec();
-        let s = signature.s().to_vec();
+        let r = signature.r().to_vec_padded(32)?;
+        let s = signature.s().to_vec_padded(32)?;
 
         let mut sig = Vec::with_capacity(r.len() + s.len());
         sig.extend_from_slice(&r);