Merge pull request #183 from aik099/setvalue-checkbox-validation-feat

stof · web-flow · commit 207f8a5f72a8 · 2025-01-09T11:28:51.000+01:00
Throw exception, when doing a "setValue" call on checkbox with a non-boolean value
diff --git a/src/BrowserKitDriver.php b/src/BrowserKitDriver.php
@@ -413,6 +413,10 @@ public function setValue(string $xpath, $value)
                 throw new DriverException('Only string values can be used for a radio input.');
             }
 
+            if (!\is_bool($value) && $field->getType() === 'checkbox') {
+                throw new DriverException('Only boolean values can be used for a checkbox input.');
+            }
+
             if (\is_bool($value) && $field->getType() === 'select') {
                 throw new DriverException('Boolean values cannot be used for a select element.');
             }

Original file line number	Diff line number	Diff line change
`@@ -413,6 +413,10 @@ public function setValue(string $xpath, $value)`
`413`	`413`	`throw new DriverException('Only string values can be used for a radio input.');`
`414`	`414`	`}`
`415`	`415`
	`416`	`+ if (!\is_bool($value) && $field->getType() === 'checkbox') {`
	`417`	`+ throw new DriverException('Only boolean values can be used for a checkbox input.');`
	`418`	`+ }`
	`419`	`+`
`416`	`420`	`if (\is_bool($value) && $field->getType() === 'select') {`
`417`	`421`	`throw new DriverException('Boolean values cannot be used for a select element.');`
`418`	`422`	`}`