Merge pull request #342 from alexpott/PHP71-NavigationTest

Fix NavigationTest::testLinks on PHP 7.1

Author: stof

.github/workflows/tests.yml

@@ -35,6 +35,8 @@ jobs:
           coverage: "none"
           php-version: "${{ matrix.php }}"
           tools: composer
+          # PHP 7.1 development web server segfaults if timezone not set.
+          ini-values: date.timezone=Europe/Paris, error_reporting=-1, display_errors=On
 
       - name: Configure for PHP >= 7.1
         if: "${{ matrix.php >= '7.1' }}"
@@ -46,8 +48,10 @@ jobs:
           composer update --no-interaction --prefer-dist
 
       - name: Setup Mink test server
+        # PHP 7.1 development web server segfaults if USE_ZEND_ALLOC not set to 0.
         run: |
           mkdir ./logs
+          export USE_ZEND_ALLOC=0
           ./vendor/bin/mink-test-server &> ./logs/mink-test-server.log &
 
       - name: Start Selenium

tests/Selenium2Config.php

@@ -42,15 +42,6 @@ public function skipMessage($testCase, $test)
             return 'Maximizing the window does not work when running the browser in Xvfb.';
         }
 
-        if (
-            'Behat\Mink\Tests\Driver\Basic\NavigationTest' === $testCase
-            && (0 === strpos($test, 'testLinks'))
-            && 'true' === getenv('GITHUB_ACTIONS')
-            && '7.1' === getenv('MATRIX_PHP')
-        ) {
-            return 'Skipping basic NavigationTest::testLinks on PHP 7.1';
-        }
-
         return parent::skipMessage($testCase, $test);
     }