Skip to content

Commit d7fa83e

Browse files
committed
Specify branch explicitly; fix Selenium2Driver workflow
1 parent 193885c commit d7fa83e

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ jobs:
3939
with:
4040
name: ${{ matrix.name }}
4141
driverRepoUrl: ${{ matrix.driverRepoUrl }}
42+
driverRepoBranch: ${{ matrix.driverRepoBranch }}
4243
php: ${{ matrix.php }}
4344
setUpCmd: ${{ matrix.setUpCmd }}
4445
testCmd: ${{ matrix.testCmd }}
@@ -49,18 +50,21 @@ jobs:
4950
include:
5051
- name: "BrowserKit (http client)"
5152
driverRepoUrl: "https://github.com/minkphp/MinkBrowserKitDriver.git"
53+
driverRepoBranch: "master"
5254
php: "7.2"
5355
# language=bash
5456
testCmd: ./vendor/bin/phpunit --colors=always --testdox --configuration ./phpunit.http_client.xml
5557

5658
- name: "BrowserKit (http kernel)"
5759
driverRepoUrl: "https://github.com/minkphp/MinkBrowserKitDriver.git"
60+
driverRepoBranch: "master"
5861
php: "7.2"
5962
# language=bash
6063
testCmd: ./vendor/bin/phpunit --colors=always --testdox
6164

6265
- name: "Selenium2"
6366
driverRepoUrl: "https://github.com/minkphp/MinkSelenium2Driver.git"
67+
driverRepoBranch: "master"
6468
php: "7.2"
6569
# language=bash
6670
setUpCmd: |
@@ -70,6 +74,7 @@ jobs:
7074
# language=bash
7175
testCmd: |
7276
export WEB_FIXTURES_BROWSER=firefox
77+
export SELENIUM_VERSION=2.53.1
7378
export DRIVER_MACHINE_BASE_PATH=/fixtures/
7479
export WEB_FIXTURES_HOST=http://host.docker.internal:8002
7580
./vendor/bin/phpunit --colors=always --testdox
@@ -79,6 +84,7 @@ jobs:
7984
8085
- name: "WebDriver-Classic"
8186
driverRepoUrl: "https://github.com/minkphp/webdriver-classic-driver.git"
87+
driverRepoBranch: "main"
8288
php: "7.4"
8389
# language=bash
8490
setUpCmd: |
@@ -102,6 +108,7 @@ jobs:
102108
with:
103109
name: ${{ matrix.name }}
104110
driverRepoUrl: ${{ matrix.driverRepoUrl }}
111+
driverRepoBranch: ${{ matrix.driverRepoBranch }}
105112
php: ${{ matrix.php }}
106113
setUpCmd: ${{ matrix.setUpCmd }}
107114
testCmd: ${{ matrix.testCmd }}
@@ -112,6 +119,7 @@ jobs:
112119
include:
113120
- name: "Chrome"
114121
driverRepoUrl: "https://gitlab.com/behat-chrome/chrome-mink-driver.git"
122+
driverRepoBranch: "main"
115123
php: "7.4"
116124
# language=bash
117125
setUpCmd: |

.github/workflows/test.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ on:
99
description: Git URL of the driver repository
1010
required: true
1111
type: string
12+
driverRepoBranch:
13+
description: Driver repository branch to check out
14+
required: true
15+
type: string
1216
php:
1317
description: PHP version for running tests
1418
required: true
@@ -32,7 +36,7 @@ jobs:
3236
steps:
3337
- name: Set up workspace for driver repo
3438
# language=bash
35-
run: git clone ${{ inputs.driverRepoUrl }} .
39+
run: git clone --single-branch --branch "${{ inputs.driverRepoBranch }}" "${{ inputs.driverRepoUrl }}" .
3640

3741
- uses: shivammathur/setup-php@v2
3842
with:

0 commit comments

Comments
 (0)