Clean up participant delete validationss

Author: experimatt

app/admin/participants.rb

@@ -5,6 +5,19 @@
 
   permit_params :name, :email, :bio, :email_confirmed_at
 
+  controller do
+    def destroy
+      resource = Participant.find(params[:id])
+      if resource.destroy
+        flash[:notice] = "Participant was successfully deleted."
+        redirect_to admin_participants_path
+      else
+        flash[:alert] = resource.errors.full_messages.to_sentence
+        redirect_to admin_participant_path(resource)
+      end
+    end
+  end
+
   includes :attendances, { presentations: { session: :event } }
 
   filter :name

app/controllers/sessions_controller.rb

@@ -56,8 +56,12 @@ def index
   end
 
   def create
+    unless current_participant.email_confirmed?
+      return render status: 403, plain: "Email confirmation required"
+    end
+
     unless Settings.allow_new_sessions?
-      return render status: 403, plain: 'Session submission is closed'
+      return render status: 403, plain: "Session submission is closed"
     end
 
     @session.attributes = session_params.except(:code_of_conduct_agreement)

app/models/participant.rb

@@ -1,5 +1,5 @@
 class Participant < ActiveRecord::Base
-  has_many :sessions
+  has_many :sessions, -> { unscope(where: :canceled_at) }, dependent: :restrict_with_error
   has_many :attendances, dependent: :destroy
   has_many :sessions_attending, :through => :attendances, :source => :session
   has_many :presentations

app/views/admin/legacy/presenters/_presenter.html.erb

@@ -6,6 +6,6 @@
     <%= presenter.email %>
   </td>
   <td>
-    <%= presenter.sessions.for_current_event.map { |session| link_to(session.title, session) }.join(", ").html_safe %>
+    <%= presenter.sessions.active.for_current_event.map { |session| link_to(session.title, session) }.join(", ").html_safe %>
  </td>
 </tr>

spec/controllers/sessions_controller_spec.rb

@@ -123,30 +123,40 @@
     let!(:event) { create(:event) }
     let(:category) { Category.last }
 
-    context "with valid values" do
-      it "creates a new session " do
+    context "when participant email is confirmed" do
+      let(:user) { create(:participant, email_confirmed_at: Time.current) }
+
+      context "with valid values" do
+        it "creates a new session" do
+          expect {
+            post :create, params: { session: { title: "new title", description: "new description", category_ids: [category.id], level_id: "2" } }
+          }.to change { Session.count }.by(1)
+          expect(response).to redirect_to assigns[:session]
+          expect(assigns[:session].title).to eq "new title"
+          expect(assigns[:session].participant).to eq user
+          expect(assigns[:session].event).to eq event
+          expect(assigns[:session].category_ids).to include category.id
+          expect(flash[:notice]).to eq "Thanks for adding your session."
+        end
+      end
 
-        expect {
-          post :create, params: { session: { title: 'new title', description: 'new description', category_ids: [category.id], level_id: '2' } }
-        }.to change { Session.count }.by(1)
-        expect(response).to redirect_to assigns[:session]
-        expect(assigns[:session].title).to eq 'new title'
-        expect(assigns[:session].participant).to eq user
-        expect(assigns[:session].event).to eq event
-        expect(assigns[:session].category_ids).to include category.id
-        expect(flash[:notice]).to eq "Thanks for adding your session."
+      context "with invalid values" do
+        it "shows the errors" do
+          expect {
+            post :create, params: { session: { title: "" } }
+          }.not_to change { Session.count }
+          expect(response).to render_template("new")
+        end
       end
     end
 
-    context "with invalid values" do
-      it "shows the errors" do
-
+    context "when participant email is not confirmed" do
+      it "returns 403 and does not create a session" do
         expect {
-          post :create, params: { session: { title: ''} }
+          post :create, params: { session: { title: "new title", description: "new description", category_ids: [category.id], level_id: "2" } }
         }.not_to change { Session.count }
-        expect(response).to render_template('new')
+        expect(response).to have_http_status(403)
       end
     end
-
   end
 end

spec/models/participant_spec.rb

@@ -52,6 +52,28 @@
     end
   end
 
+  describe "destroying" do
+    let!(:participant) { create(:participant) }
+    let!(:event) { create(:event) }
+
+    it "is prevented when the participant has sessions" do
+      create(:session, participant: participant, event: event)
+      expect { participant.destroy }.not_to change { Participant.count }
+      expect(participant.errors[:base]).to include(/Cannot delete record because dependent sessions exist/)
+    end
+
+    it "is prevented when the participant only has canceled sessions" do
+      session = create(:session, participant: participant, event: event)
+      session.update!(canceled_at: Time.current)
+      expect { participant.destroy }.not_to change { Participant.count }
+      expect(participant.errors[:base]).to include(/Cannot delete record because dependent sessions exist/)
+    end
+
+    it "is allowed when the participant has no sessions" do
+      expect { participant.destroy }.to change { Participant.count }.by(-1)
+    end
+  end
+
   describe '#attending session' do
     let!(:session1) { create(:session) }
     let!(:joe)  { create(:joe) }