ISSUE #346

* Minor improvements.

Author: Sergio García Prado

packages/core/minos-microservice-common/minos/common/config/v2.py

@@ -148,21 +148,19 @@ def _parse_periodic_interface(data: dict[str, Any]) -> dict[str, Any]:
         return data
 
     def _get_pools(self) -> dict[str, type]:
-        from ..pools import (
-            PoolFactory,
-        )
-
-        factory = PoolFactory
-
         try:
             types = self.get_by_key("pools")
         except MinosConfigException:
-            types = dict()
+            return dict()
 
         types = {name: import_module(classname) for name, classname in types.items()}
 
+        from ..pools import (
+            PoolFactory,
+        )
+
         return {
-            "factory": factory,
+            "factory": PoolFactory,
             "types": types,
         }
 

packages/core/minos-microservice-common/tests/test_common/test_config/test_v2/test_base.py

@@ -70,9 +70,9 @@ def test_injections(self):
         ]
         self.assertEqual(expected, self.config.get_injections())
 
-    def test_injections_not_defined(self):  # FIXME
+    def test_injections_not_defined(self):
         with patch.object(ConfigV2, "get_by_key", side_effect=MinosConfigException("")):
-            self.assertEqual([PoolFactory], self.config.get_injections())
+            self.assertEqual(list(), self.config.get_injections())
 
     def test_injections_not_injectable(self):
         with patch.object(ConfigV2, "_get_pools", return_value={"factory": int}):
@@ -149,9 +149,8 @@ def test_pools(self):
         self.assertEqual(expected, self.config.get_pools())
 
     def test_pools_not_defined(self):
-        expected = {"factory": PoolFactory, "types": {}}
         with patch.object(ConfigV2, "get_by_key", side_effect=MinosConfigException("")):
-            self.assertEqual(expected, self.config.get_pools())
+            self.assertEqual(dict(), self.config.get_pools())
 
     def test_services(self):
         self.assertEqual([float, int], self.config.get_services())