ISSUE #276

* Improve exception message.

Author: Sergio García Prado

packages/core/minos-microservice-aggregate/minos/aggregate/entities/refs/models.py

@@ -64,6 +64,9 @@ def __getitem__(self, item: str) -> Any:
             if item == "uuid":
                 return self.uuid
 
+            if not self.resolved:
+                raise KeyError(f"The reference is not resolved: {self!r}")
+
             try:
                 return self.data[item]
             except Exception:
@@ -89,6 +92,9 @@ def __getattr__(self, item: str) -> Any:
             if item == "data":
                 raise exc
 
+            if not self.resolved:
+                raise AttributeError(f"The reference is not resolved: {self!r}")
+
             try:
                 return getattr(self.data, item)
             except Exception:
@@ -218,7 +224,10 @@ def resolved(self) -> bool:
 
         :return: ``True`` if resolved or ``False`` otherwise.
         """
-        return not isinstance(self.data, UUID)
+        try:
+            return not isinstance(self.data, UUID)
+        except AttributeError:
+            return False
 
     def __repr__(self) -> str:
         return f"{type(self).__name__}({self.data!r})"

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_entities/test_refs/test_models.py

@@ -68,6 +68,13 @@ def test_uuid_getattr(self):
 
         self.assertEqual(uuid, value.uuid)
 
+    def test_uuid_getattr_raises(self):
+        uuid = uuid4()
+        value = Ref(uuid)
+
+        with self.assertRaises(AttributeError):
+            value.color
+
     def test_uuid_setattr(self):
         uuid_1 = uuid4()
         uuid_2 = uuid4()
@@ -83,11 +90,12 @@ def test_uuid_getitem(self):
 
         self.assertEqual(uuid, value["uuid"])
 
-    def test_model_getitem_raises(self):
-        value = Ref(Bar(uuid4(), 1))
+    def test_uuid_getitem_raises(self):
+        uuid = uuid4()
+        value = Ref(uuid)
 
         with self.assertRaises(KeyError):
-            value["year"]
+            value["color"]
 
     def test_uuid_setitem(self):
         uuid_1 = uuid4()
@@ -148,6 +156,12 @@ def test_model_getitem(self):
 
         self.assertEqual(1, value["age"])
 
+    def test_model_getitem_raises(self):
+        value = Ref(Bar(uuid4(), 1))
+
+        with self.assertRaises(KeyError):
+            value["year"]
+
     def test_model_setitem(self):
         value = Ref(Bar(uuid4(), 1))