- Added user and password to config.

issue #1283

Author: albamig

packages/plugins/minos-broker-rabbitmq/minos/plugins/rabbitmq/common.py

@@ -23,5 +23,7 @@ def with_config(self, config: Config):
         self.kwargs |= {
             "host": common_config.get("host"),
             "port": common_config.get("port"),
+            "user": common_config.get("user"),
+            "password": common_config.get("password"),
         }
         return super().with_config(config)

packages/plugins/minos-broker-rabbitmq/minos/plugins/rabbitmq/publisher.py

@@ -28,23 +28,37 @@
 class RabbitMQBrokerPublisher(BrokerPublisher):
     """RabbitMQ Broker Publisher class."""
 
-    def __init__(self, *args, host: Optional[str] = None, port: Optional[int] = None, **kwargs):
+    def __init__(
+        self,
+        *args,
+        host: Optional[str] = None,
+        port: Optional[int] = None,
+        user: Optional[str] = None,
+        password: Optional[str] = None,
+        **kwargs,
+    ):
         super().__init__(*args, **kwargs)
 
         if host is None:
             host = "localhost"
         if port is None:
             port = 5672
+        if user is None:
+            user = "guest"
+        if password is None:
+            password = "guest"
 
         self.host = host
         self.port = port
+        self.user = user
+        self.password = password
 
         self.connection = None
         self.channel = None
 
     async def _setup(self) -> None:
         await super()._setup()
-        self.connection = await connect(f"amqp://guest:guest@{self.host}:{self.port}/")
+        self.connection = await connect(f"amqp://{self.user}:{self.password}@{self.host}:{self.port}/")
         self.channel = await self.connection.channel()
 
     async def _destroy(self) -> None:

packages/plugins/minos-broker-rabbitmq/minos/plugins/rabbitmq/subscriber.py

@@ -47,6 +47,8 @@ def __init__(
         topics: Iterable[str],
         host: Optional[str] = None,
         port: Optional[int] = None,
+        user: Optional[str] = None,
+        password: Optional[str] = None,
         **kwargs,
     ):
         super().__init__(topics, **kwargs)
@@ -55,9 +57,15 @@ def __init__(
             host = "localhost"
         if port is None:
             port = 5672
+        if user is None:
+            user = "guest"
+        if password is None:
+            password = "guest"
 
         self.host = host
         self.port = port
+        self.user = user
+        self.password = password
 
         self.connection = None
 
@@ -66,7 +74,7 @@ def __init__(
 
     async def _setup(self) -> None:
         await super()._setup()
-        self.connection = await connect(f"amqp://guest:guest@{self.host}:{self.port}/")
+        self.connection = await connect(f"amqp://{self.user}:{self.password}@{self.host}:{self.port}/")
         await self._start_task()
 
     async def _destroy(self) -> None:

packages/plugins/minos-broker-rabbitmq/tests/test_config.yml

@@ -24,6 +24,8 @@ snapshot:
 broker:
   host: localhost
   port: 5672
+  user: guest
+  password: guest
   queue:
     database: order_db
     user: minos

packages/plugins/minos-broker-rabbitmq/tests/test_rabbitmq/test_common.py

@@ -23,6 +23,8 @@ def test_constructor(self):
         expected = {
             "host": common_config["host"],
             "port": common_config["port"],
+            "user": common_config["user"],
+            "password": common_config["password"],
         }
         self.assertEqual(expected, mixin.kwargs)
 

packages/plugins/minos-broker-rabbitmq/tests/test_rabbitmq/test_subscriber.py

@@ -65,6 +65,8 @@ def test_with_config(self):
         expected = {
             "host": common_config["host"],
             "port": common_config["port"],
+            "user": common_config["user"],
+            "password": common_config["password"],
         }
         self.assertEqual(expected, builder.kwargs)