Merge pull request #164 from minos-framework/issue-163-rename-autogenerated-get-aggregate-comands

#163 - Rename autogenerated "get" commands

Author: Sergio García Prado

packages/core/minos-microservice-aggregate/minos/aggregate/entities/refs/resolvers.py

@@ -65,8 +65,10 @@ async def resolve(self, data: Any, **kwargs) -> Any:
     async def _query(self, references: dict[str, set[UUID]]) -> dict[UUID, Model]:
         async with self.broker_pool.acquire() as broker:
             futures = (
-                broker.send(BrokerMessageV1(f"Get{name}s", BrokerMessageV1Payload({"uuids": uuids})))
-                for name, uuids in references.items()
+                broker.send(
+                    BrokerMessageV1(f"_Get{simplified_name}Snapshots", BrokerMessageV1Payload({"uuids": uuids}))
+                )
+                for simplified_name, uuids in references.items()
             )
             await gather(*futures)
 

packages/core/minos-microservice-aggregate/minos/aggregate/snapshots/services.py

@@ -65,8 +65,8 @@ def __init__(
     def __get_enroute__(cls, config: MinosConfig) -> dict[str, set[EnrouteDecorator]]:
         simplified_name = config.service.aggregate.rsplit(".", 1)[-1]
         return {
-            cls.__get_one__.__name__: {enroute.broker.command(f"Get{simplified_name}")},
-            cls.__get_many__.__name__: {enroute.broker.command(f"Get{simplified_name}s")},
+            cls.__get_one__.__name__: {enroute.broker.command(f"_Get{simplified_name}Snapshot")},
+            cls.__get_many__.__name__: {enroute.broker.command(f"_Get{simplified_name}Snapshots")},
             cls.__synchronize__.__name__: {enroute.periodic.event("* * * * *")},
         }
 

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_entities/test_refs/test_resolvers.py

@@ -43,7 +43,7 @@ async def test_resolve(self):
 
         self.assertEqual(1, len(observed))
         self.assertIsInstance(observed[0], BrokerMessageV1)
-        self.assertEqual("GetBars", observed[0].topic)
+        self.assertEqual("_GetBarSnapshots", observed[0].topic)
         self.assertEqual({"uuids": {self.another_uuid}}, observed[0].content)
 
         self.assertEqual(Foo(self.uuid, 1, another=Ref(Bar(self.another_uuid, 1))), resolved)

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_snapshots/test_services.py

@@ -43,8 +43,8 @@ def setUp(self) -> None:
 
     def test_get_enroute(self):
         expected = {
-            "__get_one__": {BrokerCommandEnrouteDecorator("GetOrder")},
-            "__get_many__": {BrokerCommandEnrouteDecorator("GetOrders")},
+            "__get_one__": {BrokerCommandEnrouteDecorator("_GetOrderSnapshot")},
+            "__get_many__": {BrokerCommandEnrouteDecorator("_GetOrderSnapshots")},
             "__synchronize__": {PeriodicEventEnrouteDecorator("* * * * *")},
         }
         observed = SnapshotService.__get_enroute__(self.config)