ISSUE #98

* Raise a `MinosConfigException` when requested database does not exist.

Author: Sergio García Prado

packages/core/minos-microservice-common/minos/common/config/abc.py

@@ -145,18 +145,21 @@ def get_default_database(self):
 
         :return: A ``dict`` containing the database's config values.
         """
-        return self.get_database_by_name("default")
+        return self.get_database_by_name(None)
 
-    def get_database_by_name(self, name: str) -> dict[str, Any]:
+    def get_database_by_name(self, name: Optional[str]) -> dict[str, Any]:
         """Get the database value by name.
 
         :param name: The name of the database. If ``None`` is provided then the default database will be used.
         :return: A ``dict`` containing the database's config values.
         """
+        if name is None:
+            name = "default"
+
         databases = self.get_databases()
 
         if name not in databases:
-            name = "default"
+            raise MinosConfigException(f"{name!r} database is not configured")
 
         return databases[name]
 

packages/core/minos-microservice-common/tests/test_common/test_config/test_abc.py

@@ -147,7 +147,8 @@ def test_get_database_unknown(self):
         mock = MagicMock(return_value={"default": "foo"})
         self.config._get_databases = mock
 
-        self.assertEqual("foo", self.config.get_database_by_name("unknown"))
+        with self.assertRaises(MinosConfigException):
+            self.config.get_database_by_name("unknown")
 
         self.assertEqual([call()], mock.call_args_list)
 

packages/core/minos-microservice-common/tests/test_common/test_config/test_v2/test_base.py

@@ -191,15 +191,6 @@ def test_database_default(self):
         self.assertEqual("localhost", database_config["host"])
         self.assertEqual(5432, database_config["port"])
 
-    def test_database_event(self):
-        config = ConfigV2(self.file_path, with_environment=False)
-        database_config = config.get_database_by_name("event")
-        self.assertEqual("order_db", database_config["database"])
-        self.assertEqual("minos", database_config["user"])
-        self.assertEqual("min0s", database_config["password"])
-        self.assertEqual("localhost", database_config["host"])
-        self.assertEqual(5432, database_config["port"])
-
     def test_database_query(self):
         config = ConfigV2(self.file_path, with_environment=False)
         query_database = config.get_database_by_name("query")
@@ -209,24 +200,6 @@ def test_database_query(self):
         self.assertEqual("localhost", query_database["host"])
         self.assertEqual(5432, query_database["port"])
 
-    def test_database_snapshot(self):
-        config = ConfigV2(self.file_path, with_environment=False)
-        snapshot = config.get_database_by_name("snapshot")
-        self.assertEqual("order_db", snapshot["database"])
-        self.assertEqual("minos", snapshot["user"])
-        self.assertEqual("min0s", snapshot["password"])
-        self.assertEqual("localhost", snapshot["host"])
-        self.assertEqual(5432, snapshot["port"])
-
-    def test_database_broker(self):
-        config = ConfigV2(self.file_path, with_environment=False)
-        snapshot = config.get_database_by_name("broker")
-        self.assertEqual("order_db", snapshot["database"])
-        self.assertEqual("minos", snapshot["user"])
-        self.assertEqual("min0s", snapshot["password"])
-        self.assertEqual("localhost", snapshot["host"])
-        self.assertEqual(5432, snapshot["port"])
-
     def test_database_saga(self):
         config = ConfigV2(self.file_path, with_environment=False)
         saga = config.get_database_by_name("saga")