Merge pull request #504 from minos-framework/0.8.0

0.8.0.dev3

Author: Sergio García Prado

packages/core/minos-microservice-aggregate/minos/aggregate/__init__.py

@@ -2,7 +2,7 @@
 
 __author__ = "Minos Framework Devs"
 __email__ = "[email protected]"
-__version__ = "0.8.0.dev2"
+__version__ = "0.8.0.dev3"
 
 from .actions import (
     Action,

packages/core/minos-microservice-aggregate/minos/aggregate/entities/repositories.py

@@ -197,7 +197,7 @@ async def update(self, instance: T, **kwargs) -> tuple[T, Optional[Delta]]:
         previous = await self.get(type(instance), instance.uuid)
         delta = instance.diff(previous)
         if not len(delta.fields_diff):
-            return instance
+            return instance, None
 
         entry = await self._delta_repository.submit(delta)
 

packages/core/minos-microservice-aggregate/poetry.lock

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "minos-microservice-aggregate"
-version = "0.8.0.dev2"
+version = "0.8.0.dev3"
 description = "The Aggregate pattern of the Minos Framework"
 readme = "README.md"
 repository = "https://github.com/minos-framework/minos-python"

packages/core/minos-microservice-aggregate/pyproject.toml

@@ -12,6 +12,7 @@
 from minos.aggregate import (
     AlreadyDeletedException,
     Condition,
+    Delta,
     DeltaRepositoryException,
     EntityRepository,
     NotFoundException,
@@ -145,18 +146,22 @@ async def test_update(self):
         self.assertEqual(expected, car)
         self.assertEqual(car, await self.repository.get(Car, car.uuid))
 
-        await self.repository.update(car, doors=5)
+        observed, delta = await self.repository.update(car, doors=5)
+        self.assertIsInstance(delta, Delta)
+
         expected = Car(5, "red", uuid=car.uuid, version=3, created_at=car.created_at, updated_at=car.updated_at)
-        self.assertEqual(expected, car)
-        self.assertEqual(car, await self.repository.get(Car, car.uuid))
+        self.assertEqual(expected, observed)
+        self.assertEqual(observed, await self.repository.get(Car, expected.uuid))
 
     async def test_update_no_changes(self):
         car, _ = await self.repository.create(Car, doors=3, color="blue")
 
-        await self.repository.update(car, color="blue")
+        observed, delta = await self.repository.update(car, color="blue")
+        self.assertIsNone(delta)
+
         expected = Car(3, "blue", uuid=car.uuid, version=1, created_at=car.created_at, updated_at=car.updated_at)
-        self.assertEqual(expected, car)
-        self.assertEqual(car, await self.repository.get(Car, car.uuid))
+        self.assertEqual(expected, observed)
+        self.assertEqual(observed, await self.repository.get(Car, expected.uuid))
 
     async def test_update_raises(self):
         with self.assertRaises(DeltaRepositoryException):

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_entities/test_repositories/test_base.py

@@ -2,7 +2,7 @@
 
 __author__ = "Minos Framework Devs"
 __email__ = "[email protected]"
-__version__ = "0.8.0.dev2"
+__version__ = "0.8.0.dev3"
 
 from .context import (
     SagaContext,

packages/core/minos-microservice-saga/minos/saga/__init__.py

@@ -83,18 +83,13 @@ class SagaExecutionRepositoryTestCase(MinosTestCase, ABC):
     def setUp(self) -> None:
         super().setUp()
         self.saga_execution_repository = self.build_saga_execution_repository()
+        self.execution = SagaExecution.from_definition(_SAGA)
+        self.another = SagaExecution.from_definition(_SAGA)
 
     async def asyncSetUp(self) -> None:
         await super().asyncSetUp()
-
         await self.saga_execution_repository.setup()
-
-        execution = SagaExecution.from_definition(_SAGA)
-        await execution.execute(autocommit=False)
-
-        self.execution = execution
-
-        self.another = SagaExecution.from_definition(_SAGA)
+        await self.execution.execute(autocommit=False)
 
     async def asyncTearDown(self):
         await self.saga_execution_repository.destroy()