Skip to content

Commit 8cf6238

Browse files
author
Sergio García Prado
committed
ISSUE #98
* Rename `register_factory` as `set_factory`.
1 parent e532da9 commit 8cf6238

File tree

14 files changed

+30
-30
lines changed

14 files changed

+30
-30
lines changed

‎packages/core/minos-microservice-aggregate/tests/utils.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
145145
return FakeDatabaseOperation("release")
146146

147147

148-
FakeDatabaseClient.register_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
148+
FakeDatabaseClient.set_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
149149

150150

151151
class FakeManagementDatabaseOperationFactory(ManagementDatabaseOperationFactory):
@@ -160,7 +160,7 @@ def build_delete(self, database: str) -> DatabaseOperation:
160160
return FakeDatabaseOperation("delete")
161161

162162

163-
FakeDatabaseClient.register_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
163+
FakeDatabaseClient.set_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
164164

165165

166166
class FakeTransactionDatabaseOperationFactory(TransactionDatabaseOperationFactory):
@@ -200,7 +200,7 @@ def build_query(
200200
return FakeDatabaseOperation("select")
201201

202202

203-
FakeDatabaseClient.register_factory(TransactionDatabaseOperationFactory, FakeTransactionDatabaseOperationFactory)
203+
FakeDatabaseClient.set_factory(TransactionDatabaseOperationFactory, FakeTransactionDatabaseOperationFactory)
204204

205205

206206
class FakeEventDatabaseOperationFactory(EventDatabaseOperationFactory):
@@ -253,7 +253,7 @@ def build_query_offset(self) -> DatabaseOperation:
253253
return FakeDatabaseOperation("select_max_id")
254254

255255

256-
FakeDatabaseClient.register_factory(EventDatabaseOperationFactory, FakeEventDatabaseOperationFactory)
256+
FakeDatabaseClient.set_factory(EventDatabaseOperationFactory, FakeEventDatabaseOperationFactory)
257257

258258

259259
class FakeSnapshotDatabaseOperationFactory(SnapshotDatabaseOperationFactory):
@@ -302,7 +302,7 @@ def build_query_offset(self) -> DatabaseOperation:
302302
return FakeDatabaseOperation("get_offset")
303303

304304

305-
FakeDatabaseClient.register_factory(SnapshotDatabaseOperationFactory, FakeSnapshotDatabaseOperationFactory)
305+
FakeDatabaseClient.set_factory(SnapshotDatabaseOperationFactory, FakeSnapshotDatabaseOperationFactory)
306306

307307

308308
class FakeAsyncIterator:

‎packages/core/minos-microservice-common/minos/common/database/clients/abc.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def _fetch_all(self, *args, **kwargs) -> AsyncIterator[Any]:
151151
raise NotImplementedError
152152

153153
@classmethod
154-
def register_factory(cls, base: type[DatabaseOperationFactory], impl: type[DatabaseOperationFactory]) -> None:
154+
def set_factory(cls, base: type[DatabaseOperationFactory], impl: type[DatabaseOperationFactory]) -> None:
155155
"""Register an operation factory implementation for an operation factory interface.
156156
157157
:param base: The operation factory interface.

‎packages/core/minos-microservice-common/tests/test_common/test_database/test_clients/test_abc.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
6969
return _DatabaseOperation()
7070

7171

72-
_DatabaseClient.register_factory(LockDatabaseOperationFactory, _LockDatabaseOperationFactory)
72+
_DatabaseClient.set_factory(LockDatabaseOperationFactory, _LockDatabaseOperationFactory)
7373

7474

7575
class TestDatabaseClient(CommonTestCase):
@@ -97,7 +97,7 @@ async def test_is_valid(self):
9797
self.assertEqual([call(), call()], mock.call_args_list)
9898

9999
async def test_lock(self):
100-
_DatabaseClient.register_factory(LockDatabaseOperationFactory, _LockDatabaseOperationFactory)
100+
_DatabaseClient.set_factory(LockDatabaseOperationFactory, _LockDatabaseOperationFactory)
101101
op1 = _DatabaseOperation(lock="foo")
102102
client = _DatabaseClient()
103103
self.assertIsNone(client.lock)
@@ -197,25 +197,25 @@ async def test_fetch_one(self):
197197

198198
self.assertEqual([call()], mock.call_args_list)
199199

200-
def test_register_factory(self):
200+
def test_set_factory(self):
201201
expected = {
202202
LockDatabaseOperationFactory: _LockDatabaseOperationFactory,
203203
_DatabaseOperationFactory: _DatabaseOperationFactoryImpl,
204204
}
205205
try:
206-
_DatabaseClient.register_factory(_DatabaseOperationFactory, _DatabaseOperationFactoryImpl)
206+
_DatabaseClient.set_factory(_DatabaseOperationFactory, _DatabaseOperationFactoryImpl)
207207

208208
self.assertEqual(expected, _DatabaseClient._factories)
209209
finally:
210210
_DatabaseClient._factories.pop(_DatabaseOperationFactory)
211211

212-
def test_register_factory_raises(self):
212+
def test_set_factory_raises(self):
213213
with self.assertRaises(ValueError):
214214
# noinspection PyTypeChecker
215-
_DatabaseClient.register_factory(object, DatabaseOperationFactory)
215+
_DatabaseClient.set_factory(object, DatabaseOperationFactory)
216216

217217
with self.assertRaises(ValueError):
218-
_DatabaseClient.register_factory(_DatabaseOperationFactoryImpl, _DatabaseOperationFactory)
218+
_DatabaseClient.set_factory(_DatabaseOperationFactoryImpl, _DatabaseOperationFactory)
219219

220220
def test_get_factory(self):
221221
self.assertIsInstance(

‎packages/core/minos-microservice-common/tests/utils.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
119119
return FakeDatabaseOperation("release")
120120

121121

122-
FakeDatabaseClient.register_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
122+
FakeDatabaseClient.set_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
123123

124124

125125
class FakeManagementDatabaseOperationFactory(ManagementDatabaseOperationFactory):
@@ -134,7 +134,7 @@ def build_delete(self, database: str) -> DatabaseOperation:
134134
return FakeDatabaseOperation("delete")
135135

136136

137-
FakeDatabaseClient.register_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
137+
FakeDatabaseClient.set_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
138138

139139

140140
class FakeDatabaseOperation(DatabaseOperation):

‎packages/core/minos-microservice-cqrs/tests/utils.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
118118
return FakeDatabaseOperation("release")
119119

120120

121-
FakeDatabaseClient.register_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
121+
FakeDatabaseClient.set_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
122122

123123

124124
class FakeManagementDatabaseOperationFactory(ManagementDatabaseOperationFactory):
@@ -133,4 +133,4 @@ def build_delete(self, database: str) -> DatabaseOperation:
133133
return FakeDatabaseOperation("delete")
134134

135135

136-
FakeDatabaseClient.register_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
136+
FakeDatabaseClient.set_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)

‎packages/core/minos-microservice-networks/tests/utils.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
106106
return FakeDatabaseOperation("release")
107107

108108

109-
FakeDatabaseClient.register_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
109+
FakeDatabaseClient.set_factory(LockDatabaseOperationFactory, FakeLockDatabaseOperationFactory)
110110

111111

112112
class FakeManagementDatabaseOperationFactory(ManagementDatabaseOperationFactory):
@@ -121,7 +121,7 @@ def build_delete(self, database: str) -> DatabaseOperation:
121121
return FakeDatabaseOperation("delete")
122122

123123

124-
FakeDatabaseClient.register_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
124+
FakeDatabaseClient.set_factory(ManagementDatabaseOperationFactory, FakeManagementDatabaseOperationFactory)
125125

126126

127127
class FakeBrokerQueueDatabaseOperationFactory(BrokerQueueDatabaseOperationFactory):
@@ -162,7 +162,7 @@ class FakeBrokerPublisherQueueDatabaseOperationFactory(
162162
"""For testing purposes"""
163163

164164

165-
FakeDatabaseClient.register_factory(
165+
FakeDatabaseClient.set_factory(
166166
BrokerPublisherQueueDatabaseOperationFactory, FakeBrokerPublisherQueueDatabaseOperationFactory
167167
)
168168

@@ -185,7 +185,7 @@ def build_query(
185185
return FakeDatabaseOperation("select_not_processed")
186186

187187

188-
FakeDatabaseClient.register_factory(
188+
FakeDatabaseClient.set_factory(
189189
BrokerSubscriberQueueDatabaseOperationFactory, FakeBrokerSubscriberQueueDatabaseOperationFactory
190190
)
191191

@@ -204,7 +204,7 @@ def build_submit(self, topic: str, uuid: UUID) -> DatabaseOperation:
204204
return FakeDatabaseOperation("insert_row")
205205

206206

207-
FakeDatabaseClient.register_factory(
207+
FakeDatabaseClient.set_factory(
208208
BrokerSubscriberDuplicateValidatorDatabaseOperationFactory,
209209
FakeBrokerSubscriberDuplicateValidatorDatabaseOperationFactory,
210210
)

‎packages/plugins/minos-database-aiopg/minos/plugins/aiopg/factories/aggregate/events.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,4 +303,4 @@ def build_query_offset(self) -> DatabaseOperation:
303303
return AiopgDatabaseOperation(f"SELECT MAX(id) FROM {self.build_table_name()};".strip())
304304

305305

306-
AiopgDatabaseClient.register_factory(EventDatabaseOperationFactory, AiopgEventDatabaseOperationFactory)
306+
AiopgDatabaseClient.set_factory(EventDatabaseOperationFactory, AiopgEventDatabaseOperationFactory)

‎packages/plugins/minos-database-aiopg/minos/plugins/aiopg/factories/aggregate/snapshots/impl.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,4 +234,4 @@ def build_query_offset(self) -> DatabaseOperation:
234234
)
235235

236236

237-
AiopgDatabaseClient.register_factory(SnapshotDatabaseOperationFactory, AiopgSnapshotDatabaseOperationFactory)
237+
AiopgDatabaseClient.set_factory(SnapshotDatabaseOperationFactory, AiopgSnapshotDatabaseOperationFactory)

‎packages/plugins/minos-database-aiopg/minos/plugins/aiopg/factories/aggregate/transactions.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,4 +249,4 @@ def build_query(
249249
)
250250

251251

252-
AiopgDatabaseClient.register_factory(TransactionDatabaseOperationFactory, AiopgTransactionDatabaseOperationFactory)
252+
AiopgDatabaseClient.set_factory(TransactionDatabaseOperationFactory, AiopgTransactionDatabaseOperationFactory)

‎packages/plugins/minos-database-aiopg/minos/plugins/aiopg/factories/common/locks.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ def build_release(self, hashed_key: int) -> DatabaseOperation:
3131
return AiopgDatabaseOperation("select pg_advisory_unlock(%(hashed_key)s)", {"hashed_key": hashed_key})
3232

3333

34-
AiopgDatabaseClient.register_factory(LockDatabaseOperationFactory, AiopgLockDatabaseOperationFactory)
34+
AiopgDatabaseClient.set_factory(LockDatabaseOperationFactory, AiopgLockDatabaseOperationFactory)

0 commit comments

Comments
 (0)