Merge pull request #273 from minos-framework/issue-272-resolve-references-false-default

#272 - `resolve_references` is `False` by default

Author: Sergio García Prado

packages/core/minos-microservice-cqrs/minos/cqrs/handlers.py

@@ -19,7 +19,7 @@ class PreEventHandler:
     """Pre Event Handler class."""
 
     @classmethod
-    async def handle(cls, diff: T, resolve_references: bool = True, **kwargs) -> T:
+    async def handle(cls, diff: T, resolve_references: bool = False, **kwargs) -> T:
         """Handle Ref resolution for Events.
 
         :param diff: The instance containing ``Ref`` instances.

packages/core/minos-microservice-cqrs/tests/test_cqrs/test_handlers.py

@@ -38,7 +38,7 @@ def setUp(self) -> None:
             FieldDiffContainer([FieldDiff("bars", list[Ref[Bar]], [b.uuid for b in self.bars])]),
         )
 
-    async def test_handle(self):
+    async def test_handle_resolving_dependencies(self):
         value = Event(
             self.uuid,
             "Foo",
@@ -49,29 +49,22 @@ async def test_handle(self):
         )
 
         with patch("minos.aggregate.RefResolver.resolve", return_value=value):
-            observed = await PreEventHandler.handle(self.diff)
+            observed = await PreEventHandler.handle(self.diff, resolve_references=True)
 
-        expected = Event(
-            self.uuid,
-            "Foo",
-            1,
-            Action.CREATE,
-            self.now,
-            FieldDiffContainer([FieldDiff("bars", list[Ref[Bar]], self.bars)]),
-        )
-        self.assertEqual(expected, observed)
+        self.assertEqual(value, observed)
+        self.assertEqual(self.bars, [b.data for b in observed["bars"]])
 
     async def test_handle_not_aggregate_diff(self):
         observed = await PreEventHandler.handle(56)
         self.assertEqual(56, observed)
 
     async def test_handle_without_resolving_references(self):
-        observed = await PreEventHandler.handle(self.diff, resolve_references=False)
+        observed = await PreEventHandler.handle(self.diff)
         self.assertEqual(self.diff, observed)
 
     async def test_handle_raises(self):
         with patch("minos.aggregate.RefResolver.resolve", side_effect=ValueError):
-            observed = await PreEventHandler.handle(self.diff)
+            observed = await PreEventHandler.handle(self.diff, resolve_references=True)
 
         expected = Event(
             self.uuid,