ISSUE #51

* Remove ordering constraint.

Author: Sergio García Prado

packages/core/minos-microservice-saga/minos/saga/executions/repositories/database/impl.py

@@ -38,7 +38,6 @@ def __init__(self, *args, database_key: Optional[tuple[str]] = None, **kwargs):
 
     async def _setup(self) -> None:
         await super()._setup()
-
         operation = self.database_operation_factory.build_create()
         await self.execute_on_database(operation)
 

packages/core/minos-microservice-saga/minos/saga/executions/saga.py

@@ -86,7 +86,7 @@ def __init__(
         self.user = user
 
     @classmethod
-    def from_raw(cls, raw: Union[dict[str, Any], Iterable[Any], SagaExecution], **kwargs) -> SagaExecution:
+    def from_raw(cls, raw: Union[dict[str, Any], SagaExecution], **kwargs) -> SagaExecution:
         """Build a new instance from a raw representation.
 
         :param raw: The raw representation of the instance.
@@ -96,20 +96,7 @@ def from_raw(cls, raw: Union[dict[str, Any], Iterable[Any], SagaExecution], **kw
         if isinstance(raw, cls):
             return raw
 
-        if isinstance(raw, dict):
-            raw = raw.copy()
-        else:
-            keys = [
-                "uuid",
-                "definition",
-                "status",
-                "executed_steps",
-                "paused_step",
-                "context",
-                "already_rollback",
-                "user",
-            ]
-            raw = dict(zip(keys, raw))
+        raw = dict(raw)
 
         current = raw | kwargs
         current["definition"] = Saga.from_raw(current["definition"])

packages/core/minos-microservice-saga/tests/test_saga/test_executions/test_saga/test_raw.py

@@ -35,12 +35,6 @@ def test_from_raw(self):
         observed = SagaExecution.from_raw(expected)
         self.assertEqual(expected, observed)
 
-    def test_from_raw_iterable(self):
-        with patch.object(uuid, "uuid4", return_value=UUID("a74d9d6d-290a-492e-afcc-70607958f65d")):
-            expected = SagaExecution.from_definition(ADD_ORDER, user=self.user)
-        observed = SagaExecution.from_raw(expected.raw.values())
-        self.assertEqual(expected, observed)
-
     def test_from_raw_without_user(self):
         with patch.object(uuid, "uuid4", return_value=UUID("a74d9d6d-290a-492e-afcc-70607958f65d")):
             expected = SagaExecution.from_definition(ADD_ORDER)

packages/plugins/minos-database-aiopg/minos/plugins/aiopg/clients.py

@@ -27,6 +27,9 @@
     OperationalError,
     ProgrammingError,
 )
+from psycopg2.extras import (
+    DictCursor,
+)
 
 from minos.common import (
     CircuitBreakerMixin,
@@ -180,7 +183,7 @@ async def _execute_cursor(self, operation: str, parameters: dict):
         if not await self.is_connected():
             await self.recreate()
 
-        self._cursor = await self._connection.cursor(timeout=self._cursor_timeout)
+        self._cursor = await self._connection.cursor(timeout=self._cursor_timeout, cursor_factory=DictCursor)
         try:
             await self._cursor.execute(operation=operation, parameters=parameters)
         except OperationalError as exc:

packages/plugins/minos-database-aiopg/tests/test_aiopg/test_clients.py

@@ -15,6 +15,9 @@
     OperationalError,
     ProgrammingError,
 )
+from psycopg2.extras import (
+    DictRow,
+)
 
 from minos.common import (
     ConnectionException,
@@ -171,7 +174,7 @@ async def test_fetch_one(self):
         async with AiopgDatabaseClient.from_config(self.config) as client:
             await client.execute(self.operation)
             observed = await client.fetch_one()
-        self.assertIsInstance(observed, tuple)
+        self.assertIsInstance(observed, DictRow)
 
     async def test_fetch_one_raises_programming_empty(self):
         async with AiopgDatabaseClient.from_config(self.config) as client:
@@ -199,7 +202,7 @@ async def test_fetch_all(self):
 
         self.assertGreater(len(observed), 0)
         for obs in observed:
-            self.assertIsInstance(obs, tuple)
+            self.assertIsInstance(obs, DictRow)
 
 
 if __name__ == "__main__":