ISSUE #?

* Fix bug related with the `EntityRepository.update` method.

Author: Sergio García Prado

packages/core/minos-microservice-aggregate/minos/aggregate/entities/repositories.py

@@ -197,7 +197,7 @@ async def update(self, instance: T, **kwargs) -> tuple[T, Optional[Delta]]:
         previous = await self.get(type(instance), instance.uuid)
         delta = instance.diff(previous)
         if not len(delta.fields_diff):
-            return instance
+            return instance, None
 
         entry = await self._delta_repository.submit(delta)
 

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_entities/test_repositories/test_base.py

@@ -12,6 +12,7 @@
 from minos.aggregate import (
     AlreadyDeletedException,
     Condition,
+    Delta,
     DeltaRepositoryException,
     EntityRepository,
     NotFoundException,
@@ -145,18 +146,22 @@ async def test_update(self):
         self.assertEqual(expected, car)
         self.assertEqual(car, await self.repository.get(Car, car.uuid))
 
-        await self.repository.update(car, doors=5)
+        observed, delta = await self.repository.update(car, doors=5)
+        self.assertIsInstance(delta, Delta)
+
         expected = Car(5, "red", uuid=car.uuid, version=3, created_at=car.created_at, updated_at=car.updated_at)
-        self.assertEqual(expected, car)
-        self.assertEqual(car, await self.repository.get(Car, car.uuid))
+        self.assertEqual(expected, observed)
+        self.assertEqual(observed, await self.repository.get(Car, expected.uuid))
 
     async def test_update_no_changes(self):
         car, _ = await self.repository.create(Car, doors=3, color="blue")
 
-        await self.repository.update(car, color="blue")
+        observed, delta = await self.repository.update(car, color="blue")
+        self.assertIsNone(delta)
+
         expected = Car(3, "blue", uuid=car.uuid, version=1, created_at=car.created_at, updated_at=car.updated_at)
-        self.assertEqual(expected, car)
-        self.assertEqual(car, await self.repository.get(Car, car.uuid))
+        self.assertEqual(expected, observed)
+        self.assertEqual(observed, await self.repository.get(Car, expected.uuid))
 
     async def test_update_raises(self):
         with self.assertRaises(DeltaRepositoryException):