ISSUE #469

* Improve tests.

Author: Sergio García Prado

packages/plugins/minos-database-aiopg/minos/plugins/aiopg/factories/saga.py

@@ -3,6 +3,10 @@
 )
 
 import json
+from typing import (
+    Any,
+    Optional,
+)
 from uuid import (
     UUID,
 )
@@ -88,10 +92,28 @@ def build_create(self) -> DatabaseOperation:
             ]
         )
 
-    def build_store(self, uuid: UUID, **kwargs) -> DatabaseOperation:
+    def build_store(
+        self,
+        uuid: UUID,
+        definition: dict[str, Any],
+        status: str,
+        executed_steps: list[dict[str, Any]],
+        paused_step: Optional[dict[str, Any]],
+        context: str,
+        already_rollback: bool,
+        user: Optional[UUID],
+        **kwargs,
+    ) -> DatabaseOperation:
         """Build the database operation to store a saga execution.
 
         :param uuid: The identifier of the saga execution.
+        :param definition: The ``Saga`` definition.
+        :param context: The execution context.
+        :param status: The status of the execution.
+        :param executed_steps: The executed steps of the execution.
+        :param paused_step: The paused step of the execution.
+        :param already_rollback: ``True`` if already rollback of ``False`` otherwise.
+        :param user: The user that launched the execution.
         :param kwargs: The attributes of the saga execution.
         :return: A ``DatabaseOperation`` instance.
         """
@@ -123,11 +145,17 @@ def build_store(self, uuid: UUID, **kwargs) -> DatabaseOperation:
             ;
             """
         )
-        # FIXME
-        kwargs["definition"] = json.dumps(kwargs["definition"])
-        kwargs["executed_steps"] = json.dumps(kwargs["executed_steps"])
-        kwargs["paused_step"] = json.dumps(kwargs["paused_step"])
-        return AiopgDatabaseOperation(query, {"uuid": uuid} | kwargs)
+        parameters = {
+            "uuid": uuid,
+            "definition": json.dumps(definition),
+            "status": status,
+            "executed_steps": json.dumps(executed_steps),
+            "paused_step": json.dumps(paused_step),
+            "context": context,
+            "already_rollback": already_rollback,
+            "user": user,
+        }
+        return AiopgDatabaseOperation(query, parameters)
 
     def build_load(self, uuid: UUID) -> DatabaseOperation:
         """Build the database operation to load a saga execution.

packages/plugins/minos-database-aiopg/tests/test_aiopg/test_factories/test_saga/test_factories.py

@@ -8,19 +8,29 @@
     AiopgSagaExecutionDatabaseOperationFactory,
 )
 from minos.saga import (
+    Saga,
+    SagaExecution,
     SagaExecutionDatabaseOperationFactory,
 )
 
 
+def _fn(context):
+    pass
+
+
 class TestAiopgSagaExecutionDatabaseOperationFactory(unittest.TestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.execution = SagaExecution.from_definition(Saga().local_step(_fn).commit())
+
     def test_is_subclass(self):
         self.assertTrue(issubclass(AiopgSagaExecutionDatabaseOperationFactory, SagaExecutionDatabaseOperationFactory))
 
-    @unittest.skip
     def test_build_store(self):
         factory = AiopgSagaExecutionDatabaseOperationFactory()
 
-        operation = factory.build_store(uuid4(), foo="bar")
+        operation = factory.build_store(**self.execution.raw)
         self.assertIsInstance(operation, AiopgDatabaseOperation)
 
     def test_build_load(self):

packages/plugins/minos-database-lmdb/tests/test_lmdb/test_factories/test_saga/test_factories.py

@@ -3,24 +3,45 @@
     uuid4,
 )
 
+from minos.common import (
+    ComposedDatabaseOperation,
+)
 from minos.plugins.lmdb import (
     LmdbDatabaseOperation,
     LmdbDatabaseOperationType,
     LmdbSagaExecutionDatabaseOperationFactory,
 )
 from minos.saga import (
+    Saga,
+    SagaExecution,
     SagaExecutionDatabaseOperationFactory,
 )
 
 
+def _fn(context):
+    pass
+
+
 class TestLmdbSagaExecutionDatabaseOperationFactory(unittest.TestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.execution = SagaExecution.from_definition(Saga().local_step(_fn).commit())
+
     def test_is_subclass(self):
         self.assertTrue(issubclass(LmdbSagaExecutionDatabaseOperationFactory, SagaExecutionDatabaseOperationFactory))
 
+    def test_build_create(self):
+        factory = LmdbSagaExecutionDatabaseOperationFactory()
+
+        operation = factory.build_create()
+        self.assertIsInstance(operation, ComposedDatabaseOperation)
+        self.assertEqual(0, len(operation.operations))
+
     def test_build_store(self):
         factory = LmdbSagaExecutionDatabaseOperationFactory()
 
-        operation = factory.build_store(uuid4(), foo="bar")
+        operation = factory.build_store(**self.execution.raw)
         self.assertIsInstance(operation, LmdbDatabaseOperation)
         self.assertEqual(LmdbDatabaseOperationType.CREATE, operation.type_)