ISSUE #198

* Add tests for `LocalSagaStepDecoratorMeta`.

Author: Sergio García Prado

packages/core/minos-microservice-saga/minos/saga/definitions/steps/local.py

@@ -11,7 +11,9 @@
 from typing import (
     Any,
     Optional,
+    Protocol,
     Union,
+    runtime_checkable,
 )
 
 from cached_property import (
@@ -45,7 +47,8 @@
 )
 
 
-class LocalSagaStepDecoratorWrapper(SagaStepDecoratorWrapper):
+@runtime_checkable
+class LocalSagaStepDecoratorWrapper(SagaStepDecoratorWrapper, Protocol):
     """TODO"""
 
     meta: LocalSagaStepDecoratorMeta
@@ -112,10 +115,12 @@ def __call__(self, func: LocalCallback) -> LocalSagaStepDecoratorWrapper:
         # noinspection PyTypeChecker
         return func
 
-    def on_execute(self, callback: LocalCallback, parameters: Optional[SagaContext] = None, **kwargs) -> LocalSagaStep:
+    def on_execute(
+        self, operation: Union[SagaOperation, LocalCallback], parameters: Optional[SagaContext] = None, **kwargs
+    ) -> LocalSagaStep:
         """On execute method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -124,14 +129,19 @@ def on_execute(self, callback: LocalCallback, parameters: Optional[SagaContext]
         if self.on_execute_operation is not None:
             raise MultipleOnExecuteException()
 
-        self.on_execute_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_execute_operation = operation
 
         return self
 
-    def on_failure(self, callback: LocalCallback, parameters: Optional[SagaContext] = None, **kwargs) -> LocalSagaStep:
+    def on_failure(
+        self, operation: Union[SagaOperation, LocalCallback], parameters: Optional[SagaContext] = None, **kwargs
+    ) -> LocalSagaStep:
         """On failure method.
 
-        :param callback: The callback function to be called.
+        :param operation: The callback function to be called.
         :param parameters: A mapping of named parameters to be passed to the callback.
         :param kwargs: A set of named arguments to be passed to the callback. ``parameters`` has order if it is not
             ``None``.
@@ -140,7 +150,10 @@ def on_failure(self, callback: LocalCallback, parameters: Optional[SagaContext]
         if self.on_failure_operation is not None:
             raise MultipleOnFailureException()
 
-        self.on_failure_operation = SagaOperation(callback, parameters, **kwargs)
+        if not isinstance(operation, SagaOperation):
+            operation = SagaOperation(operation, parameters, **kwargs)
+
+        self.on_failure_operation = operation
 
         return self
 

packages/core/minos-microservice-saga/tests/test_saga/test_definitions/test_steps/test_local.py

@@ -3,8 +3,11 @@
 from minos.saga import (
     EmptySagaStepException,
     LocalSagaStep,
+    LocalSagaStepDecoratorMeta,
+    LocalSagaStepDecoratorWrapper,
     MultipleOnExecuteException,
     MultipleOnFailureException,
+    SagaContext,
     SagaOperation,
     SagaStep,
     UndefinedOnExecuteException,
@@ -15,6 +18,34 @@
 )
 
 
+class TestLocalSagaStepDecoratorMeta(unittest.TestCase):
+    def test_constructor(self):
+        # noinspection PyUnusedLocal
+        @LocalSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, LocalSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, LocalSagaStepDecoratorMeta)
+        self.assertEqual(LocalSagaStep(_fn), meta.definition)
+
+    def test_on_failure(self):
+        # noinspection PyUnusedLocal
+        @LocalSagaStep()
+        def _fn(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        @_fn.on_failure()
+        def _fn2(context: SagaContext) -> SagaContext:
+            """For testing purposes"""
+
+        self.assertIsInstance(_fn, LocalSagaStepDecoratorWrapper)
+        meta = _fn.meta
+        self.assertIsInstance(meta, LocalSagaStepDecoratorMeta)
+        self.assertEqual(LocalSagaStep(_fn, on_failure=_fn2), meta.definition)
+
+
 class TestLocalSagaStep(unittest.TestCase):
     def test_on_execute_constructor(self):
         step = LocalSagaStep(on_execute=create_payment)