Merge pull request #447 from minos-framework/issue-446-fix-bug-enitity-set-non-hashable

#446 - Fix bug related with `EntitySet` and non-hashable `Entity` instances

Author: Sergio García Prado

packages/core/minos-microservice-aggregate/minos/aggregate/entities/collections.py

@@ -141,7 +141,7 @@ def decode_data(cls, decoder: DataDecoder, target: Any, type_: ModelType, **kwar
         :return: A decoded instance.
         """
         data_cls = get_args(type_.type_hints["data"])[1]
-        target = {decoder.build(v, data_cls, **kwargs) for v in target}
+        target = (decoder.build(v, data_cls, **kwargs) for v in target)
         target = {str(v["uuid"]): v for v in target}
         decoded = decoder.build(target, type_.type_hints["data"], **kwargs)
         return cls(decoded, additional_type_hints=type_.type_hints)

packages/core/minos-microservice-aggregate/tests/test_aggregate/test_entities/test_collections.py

@@ -8,6 +8,7 @@
 
 from minos.aggregate import (
     Action,
+    Entity,
     EntitySet,
     IncrementalSetDiff,
     IncrementalSetDiffEntry,
@@ -20,6 +21,10 @@
 )
 
 
+class _NotHashable(Entity):
+    foo: set[int]
+
+
 class TestEntitySet(unittest.TestCase):
     def test_data(self):
         raw = {OrderItem("John"), OrderItem("Michael")}
@@ -139,6 +144,10 @@ def test_avro_bytes(self):
         expected = EntitySet({OrderItem("John"), OrderItem("Michael")})
         self.assertEqual(expected, Model.from_avro_bytes(expected.avro_bytes))
 
+    def test_avro_bytes_not_hashable(self):
+        expected = EntitySet([_NotHashable({1}), _NotHashable({2})])
+        self.assertEqual(expected, Model.from_avro_bytes(expected.avro_bytes))
+
 
 class TestEntitySetDiff(unittest.TestCase):
     def setUp(self) -> None: