ISSUE #?

* Stop using `dir` builtin.

Author: Sergio García Prado

packages/core/minos-microservice-common/minos/common/model/abc.py

@@ -236,7 +236,7 @@ def __getitem__(self, item: str) -> Any:
             raise KeyError(f"{type(self).__name__!r} does not contain the {item!r} field.")
 
     def __setattr__(self, key: str, value: Any) -> None:
-        if key.startswith("_") or key in dir(self):
+        if key.startswith("_"):
             object.__setattr__(self, key, value)
             return
 
@@ -246,7 +246,7 @@ def __setattr__(self, key: str, value: Any) -> None:
             raise AttributeError(str(exc))
 
     def __getattr__(self, item: str) -> Any:
-        if item.startswith("_") or item in dir(self):
+        if item.startswith("_"):
             raise AttributeError(f"{type(self).__name__!r} does not contain the {item!r} attribute.")
 
         try:

packages/core/minos-microservice-common/tests/test_common/test_model/test_declarative/test_common.py

@@ -69,8 +69,8 @@ def test_setattr(self):
     def test_setattr_reserved_word(self):
         model = ReservedWordUser("foo")
         model.items = "bar"
-        self.assertEqual("bar", model.items)
-        self.assertNotEqual("bar", model.fields["items"].value)
+        self.assertIsInstance(model.items, Callable)
+        self.assertEqual("bar", model.fields["items"].value)
 
     def test_setattr_raises(self):
         model = Customer(123)

packages/core/minos-microservice-saga/minos/saga/context.py

@@ -38,7 +38,7 @@ def __delitem__(self, item: str) -> None:
             raise KeyError(f"{type(self).__name__!r} does not contain the {item!r} field")
 
     def __delattr__(self, item: str) -> None:
-        if item.startswith("_") or item in dir(self):
+        if item.startswith("_"):
             super().__delattr__(item)
             return
 

packages/core/minos-microservice-saga/tests/test_saga/test_context.py

@@ -1,5 +1,6 @@
 import unittest
 from collections.abc import (
+    Callable,
     MutableMapping,
 )
 
@@ -36,8 +37,8 @@ def test_setter(self):
     def test_setter_reserved_word(self):
         context = SagaContext()
         context.items = "bar"
-        self.assertEqual("bar", context.items)
-        self.assertNotIn("bar", context.fields)
+        self.assertIsInstance(context.items, Callable)
+        self.assertEqual("bar", context["items"])
 
     def test_deleter(self):
         context = SagaContext(one=1)
@@ -54,8 +55,8 @@ def test_deleter_attr(self):
     def test_deleter_reserved_word(self):
         context = SagaContext()
         context["items"] = "foo"
-        with self.assertRaises(AttributeError):
-            del context.items
+        del context.items
+        self.assertIsInstance(context.items, Callable)
         self.assertEqual("foo", context.fields["items"].value)
 
     def test_deleter_raises(self):