* Fix bugs related with concurrency on EntrypointLauncher.launch.

Author: Sergio García Prado

packages/core/minos-microservice-common/minos/common/launchers.py

@@ -6,6 +6,7 @@
 import warnings
 from asyncio import (
     AbstractEventLoop,
+    gather,
 )
 from enum import (
     Enum,
@@ -126,8 +127,7 @@ def launch(self) -> NoReturn:
 
         exception = None
         try:
-            self.loop.run_until_complete(self.setup())
-            self.loop.run_until_complete(self.entrypoint.__aenter__())
+            self.graceful_launch()
             logger.info("Microservice is up and running!")
             self.loop.run_forever()
         except KeyboardInterrupt as exc:  # pragma: no cover
@@ -138,13 +138,19 @@ def launch(self) -> NoReturn:
         finally:
             self.graceful_shutdown(exception)
 
+    def graceful_launch(self) -> None:
+        """Launch the execution gracefully.
+
+        :return: This method does not return anything.
+        """
+        self.loop.run_until_complete(gather(self.setup(), self.entrypoint.__aenter__()))
+
     def graceful_shutdown(self, err: Exception = None) -> None:
         """Shutdown the execution gracefully.
 
         :return: This method does not return anything.
         """
-        self.loop.run_until_complete(self.entrypoint.graceful_shutdown(err))
-        self.loop.run_until_complete(self.destroy())
+        self.loop.run_until_complete(gather(self.entrypoint.__aexit__(None, err, None), self.destroy()))
 
     @cached_property
     def entrypoint(self) -> Entrypoint:

packages/core/minos-microservice-common/minos/common/pools.py

@@ -37,8 +37,6 @@ def __init__(self, *args, maxsize: int = 10, recycle: Optional[int] = 300, alrea
 
     # noinspection PyUnresolvedReferences
     async def __acquire(self) -> Any:  # pragma: no cover
-        # FIXME: This method inheritance should be improved.
-
         if self._instances.empty() and not self._semaphore.locked():
             await self._PoolBase__create_new_instance()
 
@@ -56,8 +54,14 @@ async def __acquire(self) -> Any:  # pragma: no cover
                 return await self._PoolBase__acquire()
 
         self._used.add(instance)
+        logger.debug(f"Acquired instance: {instance!r}")
         return instance
 
+    # noinspection PyUnresolvedReferences
+    async def __release(self, instance: Any) -> Any:  # pragma: no cover
+        await self._PoolBase__release(instance)
+        logger.debug(f"Released instance: {instance!r}")
+
     def acquire(self, *args, **kwargs) -> P:
         """Acquire a new instance wrapped on an asynchronous context manager.
 
@@ -66,7 +70,7 @@ def acquire(self, *args, **kwargs) -> P:
         :return: An asynchronous context manager.
         """
         # noinspection PyUnresolvedReferences
-        return ContextManager(self.__acquire, self._PoolBase__release)
+        return ContextManager(self.__acquire, self.__release)
 
     async def _destroy(self) -> None:
         if len(self._used):

packages/core/minos-microservice-common/minos/common/ports.py

@@ -23,6 +23,7 @@ async def start(self) -> None:
             return await self._start()
         except Exception as exc:
             logger.exception(f"Raised an exception on {self!r} start: {exc!r}")
+            raise exc
 
     @abstractmethod
     def _start(self):
@@ -38,6 +39,7 @@ async def stop(self, err: Exception = None) -> None:
             return await self._stop(err)
         except Exception as exc:
             logger.exception(f"Raised an exception on {self!r} stop: {exc!r}")
+            raise exc
 
     @abstractmethod
     async def _stop(self, err: Exception = None) -> None:

packages/core/minos-microservice-common/tests/test_common/test_ports.py

@@ -47,7 +47,8 @@ async def test_start_raises(self):
         mock = AsyncMock(side_effect=ValueError)
         port._start = mock
 
-        await port.start()
+        with self.assertRaises(ValueError):
+            await port.start()
 
         self.assertEqual([call()], mock.call_args_list)
 
@@ -67,7 +68,8 @@ async def test_stop_raises(self):
         mock = AsyncMock(side_effect=ValueError)
         port._stop = mock
 
-        await port.stop()
+        with self.assertRaises(ValueError):
+            await port.stop()
 
         self.assertEqual([call(None)], mock.call_args_list)
 

packages/core/minos-microservice-common/tests/utils.py

@@ -24,7 +24,7 @@ def __init__(self, *args, **kwargs):
     async def __aenter__(self):
         """For testing purposes."""
 
-    async def graceful_shutdown(*args, **kwargs):
+    async def __aexit__(self, exc_type, exc_val, exc_tb):
         """For testing purposes."""