Skip to content

Commit f693ba5

Browse files
author
Sergio García Prado
committed
ISSUE #150
* Add docstring.
1 parent dc0e332 commit f693ba5

File tree

8 files changed

+36
-31
lines changed

8 files changed

+36
-31
lines changed

packages/core/minos-microservice-common/minos/common/builders.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ def new(cls: type[B]) -> B:
6363
return cls()
6464

6565
def with_cls(self: B, cls: type) -> B:
66-
"""TODO
66+
"""Set class to be built.
6767
68-
:param cls: TODO
69-
:return: TODO
68+
:param cls: The class to be set.
69+
:return: This method return the builder instance.
7070
"""
7171
self.instance_cls = cls
7272
return self
@@ -92,7 +92,7 @@ def with_config(self: B, config: Config) -> B:
9292
def build(self) -> Instance:
9393
"""Build the instance.
9494
95-
:return: A ``BrokerSubscriber`` instance.
95+
:return: A ``Instance`` instance.
9696
"""
9797
return self.instance_cls(**self.kwargs)
9898

packages/core/minos-microservice-networks/minos/networks/brokers/collections/queues/pg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ async def _dequeue_rows(self, cursor: Cursor) -> list[Any]:
201201

202202

203203
class PostgreSqlBrokerQueueBuilder(Builder):
204-
"""TODO"""
204+
"""PostgreSql Broker Queue Builder class."""
205205

206206
def with_config(self, config: Config):
207207
"""Set config.

packages/core/minos-microservice-networks/minos/networks/brokers/publishers/abc.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030

3131
if TYPE_CHECKING:
3232
from .queued import (
33-
QueuedBrokerPublisher,BrokerPublisherQueue
33+
BrokerPublisherQueue,
34+
QueuedBrokerPublisher,
3435
)
3536

3637
logger = logging.getLogger(__name__)
@@ -81,10 +82,10 @@ def __init__(
8182
self.queued_cls = queued_cls
8283

8384
def with_queued_cls(self, queued_cls: type[QueuedBrokerPublisher]):
84-
"""TODO
85+
"""Set the queued class.
8586
86-
:param queued_cls: TODO
87-
:return: TODO
87+
:param queued_cls: A subclass of ``QueuedBrokerPublisher``.
88+
:return: This method return the builder instance.
8889
"""
8990
self.queued_cls = queued_cls
9091

@@ -114,10 +115,10 @@ def _with_builders_from_config(self, config):
114115
self.with_queue(broker_publisher_config["queue"])
115116

116117
def with_queue(self, queue: Union[type[BrokerPublisherQueue], Builder[BrokerPublisherQueue]]):
117-
"""TODO
118+
"""Set the queue builder.
118119
119-
:param queue: TODO
120-
:return: TODO
120+
:param queue: The queue builder to be set.
121+
:return: This method return the builder instance.
121122
"""
122123
if not isinstance(queue, Builder):
123124
queue = queue.get_builder()

packages/core/minos-microservice-networks/minos/networks/brokers/subscribers/abc.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -123,20 +123,20 @@ def __init__(
123123
self.queued_cls = queued_cls
124124

125125
def with_idempotent_cls(self, idempotent_cls: type[IdempotentBrokerSubscriber]):
126-
"""TODO
126+
"""Set the idempotent class.
127127
128-
:param idempotent_cls: TODO
129-
:return: TODO
128+
:param idempotent_cls: A subclass of ``IdempotentBrokerSubscriber``.
129+
:return: This method return the builder instance.
130130
"""
131131
self.idempotent_cls = idempotent_cls
132132

133133
return self
134134

135135
def with_queued_cls(self, queued_cls: type[QueuedBrokerSubscriber]):
136-
"""TODO
136+
"""Set the queued class.
137137
138-
:param queued_cls: TODO
139-
:return: TODO
138+
:param queued_cls: A subclass of ``QueuedBrokerSubscriber``.
139+
:return: This method return the builder instance.
140140
"""
141141
self.queued_cls = queued_cls
142142

@@ -174,21 +174,21 @@ def with_duplicate_detector(
174174
self,
175175
duplicate_detector: Union[type[BrokerSubscriberDuplicateDetector], Builder[BrokerSubscriberDuplicateDetector]],
176176
):
177-
"""TODO
177+
"""Set the duplicate detector.
178178
179-
:param duplicate_detector: TODO
180-
:return: TODO
179+
:param duplicate_detector: The duplicate detector to be set.
180+
:return: This method return the builder instance.
181181
"""
182182
if not isinstance(duplicate_detector, Builder):
183183
duplicate_detector = duplicate_detector.get_builder()
184184
self.duplicate_detector_builder = duplicate_detector.copy()
185185
return self
186186

187187
def with_queue(self, queue: Union[type[BrokerSubscriberQueue], BrokerSubscriberQueueBuilder]):
188-
"""TODO
188+
"""Set the queue builder.
189189
190-
:param queue: TODO
191-
:return: TODO
190+
:param queue: The queue to be set.
191+
:return: This method return the builder instance.
192192
"""
193193
if not isinstance(queue, Builder):
194194
queue = queue.get_builder()

packages/core/minos-microservice-networks/minos/networks/brokers/subscribers/idempotent/detectors/pg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async def _is_valid(self, topic: str, uuid: UUID) -> bool:
6969

7070

7171
class PostgreSqlBrokerSubscriberDuplicateDetectorBuilder(Builder[PostgreSqlBrokerSubscriberDuplicateDetector]):
72-
"""TODO"""
72+
"""PostgreSql Broker Subscriber Duplicate Detector Builder class."""
7373

7474
def with_config(self, config: Config):
7575
"""Set config.

packages/core/minos-microservice-networks/tests/test_networks/test_brokers/test_publishers/test_abc.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,29 @@
44
)
55
from unittest.mock import (
66
AsyncMock,
7-
call, MagicMock,
7+
MagicMock,
8+
call,
89
)
910

1011
from minos.common import (
1112
Builder,
13+
Config,
14+
MinosConfigException,
1215
SetupMixin,
13-
Config, MinosConfigException,
1416
)
1517
from minos.networks import (
1618
BrokerMessage,
1719
BrokerMessageV1,
1820
BrokerMessageV1Payload,
1921
BrokerPublisher,
2022
BrokerPublisherBuilder,
23+
InMemoryBrokerPublisher,
2124
InMemoryBrokerPublisherQueue,
2225
QueuedBrokerPublisher,
23-
InMemoryBrokerPublisher,
2426
)
25-
from tests.utils import CONFIG_FILE_PATH
27+
from tests.utils import (
28+
CONFIG_FILE_PATH,
29+
)
2630

2731

2832
class _BrokerPublisher(BrokerPublisher):

packages/plugins/minos-broker-kafka/minos/plugins/kafka/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def __init__(self, *args, circuit_breaker_exceptions: Iterable[type] = tuple(),
2525

2626

2727
class KafkaBrokerBuilderMixin(Builder):
28-
"""TODO"""
28+
"""Kafka Broker Builder Mixin class."""
2929

3030
def with_config(self, config: Config):
3131
"""Set config.

packages/plugins/minos-broker-kafka/minos/plugins/kafka/publisher.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def _bootstrap_servers(self):
121121

122122

123123
class KafkaBrokerPublisherBuilder(BrokerPublisherBuilder[KafkaBrokerPublisher], KafkaBrokerBuilderMixin):
124-
"""TODO"""
124+
"""Kafka Broker Publisher Builder class."""
125125

126126

127127
KafkaBrokerPublisher.set_builder(KafkaBrokerPublisherBuilder)

0 commit comments

Comments
 (0)