tighten/address lint

Author: minrk

eslint.config.mjs

@@ -5,15 +5,15 @@ import js from "@eslint/js";
 export default defineConfig([
   js.configs.recommended,
   {
-    files: ["**/*.js"],
+    files: ["bin/*", "**/*.js"],
     languageOptions: {
       sourceType: "commonjs",
       globals: {
         ...globals.node,
       },
     },
     rules: {
-      "no-unused-vars": "off",
+      "no-unused-vars": ["error", { args: "none" }],
     },
   },
   {

lib/configproxy.js

@@ -14,8 +14,6 @@ var http = require("http"),
   path = require("path"),
   EventEmitter = require("events").EventEmitter,
   httpProxy = require("http-proxy-3"),
-  winston = require("winston"),
-  util = require("util"),
   defaultLogger = require("./log").defaultLogger,
   metrics = require("./metrics");
 
@@ -171,7 +169,7 @@ class ConfigurableProxy extends EventEmitter {
       });
     }
     options.ws = true;
-    var proxy = (this.proxy = httpProxy.createProxyServer(options));
+    this.proxy = httpProxy.createProxyServer(options);
 
     // tornado-style regex routing,
     // because cross-language cargo-culting is always a good idea

lib/testutil.js

@@ -9,7 +9,7 @@ var defaultLogger = require("./log").defaultLogger;
 
 var servers = [];
 
-var addTarget = (exports.addTarget = function (proxy, path, port, websocket, targetPath) {
+function addTarget(proxy, path, port, websocket, targetPath) {
   var target = "http://127.0.0.1:" + port;
   if (targetPath) {
     target = target + targetPath;
@@ -48,15 +48,11 @@ var addTarget = (exports.addTarget = function (proxy, path, port, websocket, tar
     // so that activity can more easily be measured
     return proxy._routes.update(path, { last_activity: proxy._setup_timestamp });
   });
-});
-
-var addTargetRedirecting = (exports.addTargetRedirecting = function (
-  proxy,
-  path,
-  port,
-  targetPath,
-  redirectTo
-) {
+}
+
+exports.addTarget = addTarget;
+
+exports.addTargetRedirecting = function (proxy, path, port, targetPath, redirectTo) {
   // Like the above, but the server returns a redirect response with a Location header.
   // Cannot use default arguments as they are apparently not supported.
   var target = "http://127.0.0.1:" + port;
@@ -75,7 +71,7 @@ var addTargetRedirecting = (exports.addTargetRedirecting = function (
     server.listen(port);
     servers.push(server);
   });
-});
+};
 
 function addTargets(proxy, paths, port) {
   if (paths.length === 0) {