Merge pull request jupyterhub#540 from jupyterhub/pre-commit-ci-update-config

[pre-commit.ci] pre-commit autoupdate, fix eslint hook for eslint 9

Author: minrk

.eslintrc.js

@@ -14,10 +14,12 @@ repos:
     rev: v6.2.1
     hooks:
       - id: beautysh
+        additional_dependencies:
+          - setuptools
 
   # Autoformat: markdown, javacsript
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: v3.0.3
+    rev: v4.0.0-alpha.8
     hooks:
       - id: prettier
         args:
@@ -26,9 +28,13 @@ repos:
 
   # Lint
   - repo: https://github.com/pre-commit/mirrors-eslint
-    rev: v8.53.0
+    rev: v9.26.0
     hooks:
       - id: eslint
+        additional_dependencies:
+          - "eslint@^9.26.0"
+          - "@eslint/js@^9.26.0"
+          - "globals@^16.1.0"
 
 # pre-commit.ci config reference: https://pre-commit.ci/#configuration
 ci:

.jshintrc

@@ -0,0 +1,32 @@
+const globals = require("globals");
+const { defineConfig } = require("eslint/config");
+const js = require("@eslint/js");
+
+module.exports = defineConfig([
+  js.configs.recommended,
+  {
+    files: ["bin/*", "**/*.js"],
+    languageOptions: {
+      sourceType: "commonjs",
+      globals: {
+        ...globals.node,
+      },
+    },
+    rules: {
+      "no-unused-vars": ["error", { args: "none" }],
+    },
+  },
+  {
+    files: ["test/**/*.js"],
+    languageOptions: {
+      sourceType: "commonjs",
+      globals: {
+        ...globals.node,
+        ...globals.jasmine,
+      },
+    },
+    rules: {
+      "no-unused-vars": "off",
+    },
+  },
+]);

.pre-commit-config.yaml

@@ -14,8 +14,6 @@ var http = require("http"),
   path = require("path"),
   EventEmitter = require("events").EventEmitter,
   httpProxy = require("http-proxy-3"),
-  winston = require("winston"),
-  util = require("util"),
   defaultLogger = require("./log").defaultLogger,
   metrics = require("./metrics");
 
@@ -171,7 +169,7 @@ class ConfigurableProxy extends EventEmitter {
       });
     }
     options.ws = true;
-    var proxy = (this.proxy = httpProxy.createProxyServer(options));
+    this.proxy = httpProxy.createProxyServer(options);
 
     // tornado-style regex routing,
     // because cross-language cargo-culting is always a good idea

eslint.config.cjs

@@ -9,7 +9,7 @@ var defaultLogger = require("./log").defaultLogger;
 
 var servers = [];
 
-var addTarget = (exports.addTarget = function (proxy, path, port, websocket, targetPath) {
+function addTarget(proxy, path, port, websocket, targetPath) {
   var target = "http://127.0.0.1:" + port;
   if (targetPath) {
     target = target + targetPath;
@@ -48,15 +48,11 @@ var addTarget = (exports.addTarget = function (proxy, path, port, websocket, tar
     // so that activity can more easily be measured
     return proxy._routes.update(path, { last_activity: proxy._setup_timestamp });
   });
-});
-
-var addTargetRedirecting = (exports.addTargetRedirecting = function (
-  proxy,
-  path,
-  port,
-  targetPath,
-  redirectTo
-) {
+}
+
+exports.addTarget = addTarget;
+
+exports.addTargetRedirecting = function (proxy, path, port, targetPath, redirectTo) {
   // Like the above, but the server returns a redirect response with a Location header.
   // Cannot use default arguments as they are apparently not supported.
   var target = "http://127.0.0.1:" + port;
@@ -75,7 +71,7 @@ var addTargetRedirecting = (exports.addTargetRedirecting = function (
     server.listen(port);
     servers.push(server);
   });
-});
+};
 
 function addTargets(proxy, paths, port) {
   if (paths.length === 0) {