Skip to content

Commit 5689a96

Browse files
authored
Merge pull request #49 from mintopia/feature/frankenphp
Blacklist prometheus metrics endpoint from OpenTelemetry traces
2 parents e7300c6 + f6f6a31 commit 5689a96

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

app/Http/Middleware/MeasureRequest.php

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,17 @@ public function handle(Request $request, Closure $next): Response
2626
if ($name === null) {
2727
$name = $request->getRequestUri();
2828
}
29+
30+
$blacklist = config('open-telemetry.traces.disabledroutes', []);
31+
if (in_array($name, $blacklist)) {
32+
return $next($request);
33+
}
34+
35+
$blacklist = config('open-telemetry.traces.disabledpaths', []);
36+
if (in_array($request->getRequestUri(), $blacklist)) {
37+
return $next($request);
38+
}
39+
2940
$trace = $request->header('traceparent');
3041
$state = $request->header('tracestate');
3142
$span = OpenTelemetry::startSpan(name: "{$request->getMethod()} {$name}", parentTrace: $trace, parentState: $state);

config/open-telemetry.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,11 @@
1313
'version' => env('OPENTELEMETRY_SERVICE_VERSION', '1.0.0'),
1414
],
1515
'environment' => env('OPENTELEMETRY_ENVIRONMENT', config('app.env')),
16+
'traces' => [
17+
'disabledroutes' => [
18+
],
19+
'disabledpaths' => [
20+
'/' . env('PROMETHEUS_PATH', 'prometheus'),
21+
]
22+
],
1623
];

0 commit comments

Comments
 (0)