ci(release): Use release flag to determine dryRun for release script

Author: minwork

tools/scripts/release/cli.ts

@@ -19,7 +19,7 @@ export function parseReleaseCliOptions() {
       alias: 'd',
       description: 'Whether or not to perform a dry-run of the release process, defaults to true',
       type: 'boolean',
-      default: true,
+      default: false,
     })
     .option('verbose', {
       description: 'Whether or not to enable verbose logging, defaults to false',
@@ -44,10 +44,11 @@ export function parseReleaseCliOptions() {
     .parseAsync();
 }
 
-export function parseReleaseOptions({ channel }: { channel?: ReleaseChannel }): {
+export function parseReleaseOptions({ channel, dryRun }: Awaited<ReturnType<typeof parseReleaseCliOptions>>): {
   isPrerelease: boolean;
   preid?: string;
   tag: ReleaseChannel;
+  dryRun?: boolean;
 } {
   let isPrerelease: boolean;
   let preid: ReleasePreidValue;
@@ -81,9 +82,19 @@ export function parseReleaseOptions({ channel }: { channel?: ReleaseChannel }):
   preid = releaseChannelPreid[selectedChannel];
   tag = selectedChannel;
 
+  const releaseEnabled = process.env.RELEASE_ENABLED === '1' || process.env.RELEASE_ENABLED === 'true';
+
+  console.info(
+    printHeader('release', 'yellow'),
+    `Live release enabled? ${releaseEnabled ? chalk.green('Yes') : chalk.red('No')} (RELEASE_ENABLED=${
+      process.env.RELEASE_ENABLED
+    })\n`
+  );
+
   return {
     isPrerelease,
     preid,
     tag,
+    dryRun: dryRun || !releaseEnabled,
   };
 }

tools/scripts/release/release.ts

@@ -11,47 +11,39 @@ import { handlePrereleaseChangelog, handleRegularReleaseChangelog } from './chan
 (async () => {
   const options = await parseReleaseCliOptions();
   const graph = await createProjectGraphAsync({ exitOnError: true });
-  const { tag, preid, isPrerelease } = parseReleaseOptions(options);
+  const { publishOnly, projects, verbose, otp } = options;
+  const { tag, preid, isPrerelease, dryRun } = parseReleaseOptions(options);
 
-  const releaseEnabled = process.env.RELEASE_ENABLED === '1' || process.env.RELEASE_ENABLED === 'true';
-
-  console.info(
-    printHeader('release', 'yellow'),
-    `Live release enabled? ${releaseEnabled ? chalk.green('Yes') : chalk.red('No')} (RELEASE_ENABLED=${
-      process.env.RELEASE_ENABLED
-    })\n`
-  );
-
-  let projectsList: string[] = options.projects ?? [];
+  let projectsList: string[] = projects ?? [];
 
   // Create new version and update changelog if not only publishing
-  if (options.publishOnly) {
+  if (publishOnly) {
     console.log(printHeader('mode', 'cyanBright'), `Publish only, skipping version and changelog\n`);
   } else {
     if (isPrerelease) {
       const versionData = await handlePrereleaseVersioning({
         preid,
-        projects: options.projects,
-        dryRun: options.dryRun,
-        verbose: options.verbose,
+        projects,
+        dryRun,
+        verbose,
       });
       await handlePrereleaseChangelog({
         versionData,
-        dryRun: options.dryRun,
-        verbose: options.verbose,
+        dryRun,
+        verbose,
       });
     } else {
       const versionData = await handleRegularReleaseVersioning({
         preid,
-        projects: options.projects,
-        dryRun: options.dryRun,
-        verbose: options.verbose,
+        projects: projects,
+        dryRun,
+        verbose,
       });
 
       await handleRegularReleaseChangelog({
         versionData,
-        dryRun: options.dryRun,
-        verbose: options.verbose,
+        dryRun,
+        verbose,
       });
     }
   }
@@ -61,12 +53,12 @@ import { handlePrereleaseChangelog, handleRegularReleaseChangelog } from './chan
 
   // The returned number value from releasePublish will be zero if all projects are published successfully, non-zero if not
   const publishProjectsResult = await releasePublish({
-    dryRun: options.dryRun,
-    verbose: options.verbose,
+    dryRun,
+    verbose,
     projects: projectsList,
     tag,
     registry: 'https://registry.npmjs.org/',
-    otp: options.otp,
+    otp,
   });
 
   const publishStatus = Object.values(publishProjectsResult).reduce((sum, { code }) => sum + code, 0);